After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616386 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: policykit-gnome
Classification: Platform
Component: authentication dialog
unspecified
Other Linux
: Normal normal
: ---
Assigned To: policykit-gnome-maint
policykit-gnome-maint
Depends on:
Blocks: 585391
 
 
Reported: 2010-04-21 10:57 UTC by André Klapper
Modified: 2010-06-01 13:50 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
Trivial patch (2.37 KB, patch)
2010-04-21 11:01 UTC, André Klapper
none Details | Review
Use accessor functions (2.61 KB, patch)
2010-04-21 15:37 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description André Klapper 2010-04-21 10:57:10 UTC
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588339, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.
Comment 1 André Klapper 2010-04-21 11:01:56 UTC
Created attachment 159243 [details] [review]
Trivial patch

No GTK+ bump required.
Comment 2 Javier Jardón (IRC: jjardon) 2010-04-21 15:37:50 UTC
Created attachment 159264 [details] [review]
Use accessor functions

A bit improved version: store the var instead calling the function several times
Comment 3 Stéphane Maniaci 2010-04-24 00:49:59 UTC
Might be a stupid question, but where did you declared content_area and action_area in your patch ?
Comment 4 André Klapper 2010-04-24 12:42:02 UTC
+  content_area = gtk_dialog_get_content_area (GTK_DIALOG (dialog));
+  action_area = gtk_dialog_get_action_area (GTK_DIALOG (dialog));
Comment 5 André Klapper 2010-05-12 13:01:21 UTC
Maintainer: ping.
Comment 6 David Zeuthen (not reading bugmail) 2010-06-01 13:49:49 UTC
Comment on attachment 159264 [details] [review]
Use accessor functions

Committed. Thanks.