GNOME Bugzilla – Bug 616265
Add a GSettings plugin that provides the same services as the GConf plugin
Last modified: 2010-07-04 15:01:36 UTC
...see summary ;)
Can we refactor the gconf plugin to something that can take the settings from gconf/gsettings/win-registry/... I belive most of the code is the same.
Yes, a start of this is already in the gconf plugin. Oh and GSettings has a GConf backend too btw ;)
Unfortunately GSettings is completely thread-unaware at the moment and even reading settings from different threads won't work...
Created attachment 165178 [details] [review] gsettings: Initial version of GSettings plugin This only provides an audio sink element for now. Fixes bug #616265.
Created attachment 165179 [details] [review] gsettings: Initial version of GSettings plugin This only provides an audio sink element for now. Fixes bug #616265.
- schema should be org.freedesktop.gstreamer.xyz (changed already) - "Audio/Audio conferencing" ? Should that be Audio/Video ? (changed already) - should we use this as an opportunity to reshuffle things a little? e.g. "audiosink" sounds like the default, but is really just the 'soundeventaudiosink', whereas musicaudiosink is what most people would consider the default (IMHO). So: - maybe make music the default value for the profile property? - rename 'audiosink' to 'eventsaudiosink' or somesuch? - do we need different schemas here? (ask gnome people?) - g_settings_new ("org.freedesktop.gstreamer.0.10") Is the 0.10 going to be a problem or significant in any way? (ie. 0.10 not being a single unit, but two units in a way) - "GSettings plugin library" => "GSettings plugin" ? Looks good otherwise.
Created attachment 165186 [details] [review] gsettings: Initial version of GSettings plugin This provides audio/video sources and sinks. Fixes bug #616265.
(In reply to comment #6) > - should we use this as an opportunity to reshuffle things a little? > e.g. "audiosink" sounds like the default, but is really just the > 'soundeventaudiosink', whereas musicaudiosink is what most > people would consider the default (IMHO). So: > > - maybe make music the default value for the profile property? > > - rename 'audiosink' to 'eventsaudiosink' or somesuch? Changed that but it's "sounds-audiosink" now. Events sounds a bit weird IMHO. > - do we need different schemas here? (ask gnome people?) Why would we need a different schema for that? > - g_settings_new ("org.freedesktop.gstreamer.0.10") > Is the 0.10 going to be a problem or significant in any > way? (ie. 0.10 not being a single unit, but two units in a way) That's no problem, that string isn't parsed inside GSettings AFAIK and the hierarchy in the string is just convention. I've changed it to org.freedesktop.gstreamer-0.10.default-elements btw, this prevents conflicts with any core GSettings schemas we might want to have in the future or not ;) And I've added the other 3 elements now. Should be ready to go in ;)
Wouldn't gsettings-editor present this as a tree separated by dots? Or would that just make a list of all schemas?
You mean dconf-editor? No idea but good point. What do you suggest?
commit 0d2fc6a7303cbd0db9675c14dd3e1dfc6ba0b2cc Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Sat Jul 3 16:15:34 2010 +0200 gsettings: Initial version of GSettings plugin This provides audio/video sources and sinks. Fixes bug #616265.