After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616195 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: 1.4.0
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks: 585391
 
 
Reported: 2010-04-19 15:45 UTC by André Klapper
Modified: 2010-06-06 16:52 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
Fix libtomboy build with -DGSEAL_ENABLE (2.05 KB, patch)
2010-05-03 19:13 UTC, Sandy Armstrong
committed Details | Review

Description André Klapper 2010-04-19 15:45:36 UTC
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

(Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588339, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.)
Comment 1 Sandy Armstrong 2010-05-03 19:13:30 UTC
Created attachment 160219 [details] [review]
Fix libtomboy build with -DGSEAL_ENABLE
Comment 2 Sandy Armstrong 2010-05-03 19:15:48 UTC
I've yet to test this with gtk+ >= 2.20.

I'll try to get to it soon but if others get a chance first, do let me know.
Comment 3 André Klapper 2010-05-21 11:51:08 UTC
Sandy: gtk_widget_get_window() in Gtk+ itself has been available since 2.14, so if I get it right no gtk+ 2.20 is needed at all here (don't know about gtk-sharp relation here though).
So could this get in?
Comment 4 Sandy Armstrong 2010-05-24 13:43:20 UTC
Andre, what I meant was that I've only tested with < 2.20.  If I have missed some sealings, this would break the build for >= 2.20.

I'm back to half days now so I should be able to find time to try this in a VM.