After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 616049 - Use correct icon names from the spec
Use correct icon names from the spec
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-17 20:51 UTC by Andreas Proschofsky
Modified: 2010-07-16 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-control-center-icon-naming.patch (4.17 KB, patch)
2010-04-17 20:54 UTC, Andreas Proschofsky
rejected Details | Review
gnomecc-shell-icon.patch (689 bytes, patch)
2010-04-17 21:40 UTC, Andreas Proschofsky
rejected Details | Review

Description Andreas Proschofsky 2010-04-17 20:51:33 UTC
For GNOME 3 all apps should conform to the Freedesktop.org icon-naming-spec.

See http://live.gnome.org/GnomeGoals/CorrectIconNames for background.
Comment 1 Andreas Proschofsky 2010-04-17 20:54:08 UTC
Created attachment 158975 [details] [review]
gnome-control-center-icon-naming.patch

This covers all instances of wrong icon naming, that I found. Not sure about the two gtk-dialog-question > dialog-question renames though, the icon doesn't show up for me after renaming.
Comment 2 Andreas Proschofsky 2010-04-17 21:40:36 UTC
Created attachment 158988 [details] [review]
gnomecc-shell-icon.patch

Another little fix for the shell-icon
Comment 3 Jens Granseuer 2010-04-18 10:10:24 UTC
Maybe the art team can verify?
Comment 4 Hylke Bons 2010-04-18 12:05:51 UTC
These are correct.
Thanks for taking care of this. :)
Comment 5 Andreas Proschofsky 2010-04-19 08:32:32 UTC
Before committing: I'm still not quite sure about the first patch myself, so some advice here would be great. To make my complete lack of coding skills public (still learning ;-) ):

I guess it is wrong to replace the icon names in all the instances where gtk_image_set_from_stock is used (cause it simply won't work, as the icon-naming-spec doesn't cover stock icons). So: Am I right that the direct references to specific icon names are just a "bug" in the current code, and the corresponding variables should be used instead. To give an example:

gtk_image_set_from_stock (image, "gtk-missing-image", size);

should be:

gtk_image_set_from_stock (image, GTK_STOCK_MISSING_IMAGE, size);

So in the future GTK+ would correctly look up the icon-name from the spec before the included stock-icon.

@Hylke: Am I right in my assumptions, essentially in regards to the GTK+ plans?
Comment 6 Thomas Wood 2010-07-16 15:05:51 UTC
I've fixed this in git by patching the .desktop file and the GtkBuilder file, since the shell has changed a lot since the original patches.

commit 5147efce71b30ee7c15b321bef273daf6fcd3257
Author: Thomas Wood <thomas.wood@intel.com>
Date:   Fri Jul 16 16:04:11 2010 +0100

    shell: use the icon naming specification icon names
    
    Fixes bug 616049  - Use correct icon names from the spec