GNOME Bugzilla – Bug 616049
Use correct icon names from the spec
Last modified: 2010-07-16 15:07:12 UTC
For GNOME 3 all apps should conform to the Freedesktop.org icon-naming-spec. See http://live.gnome.org/GnomeGoals/CorrectIconNames for background.
Created attachment 158975 [details] [review] gnome-control-center-icon-naming.patch This covers all instances of wrong icon naming, that I found. Not sure about the two gtk-dialog-question > dialog-question renames though, the icon doesn't show up for me after renaming.
Created attachment 158988 [details] [review] gnomecc-shell-icon.patch Another little fix for the shell-icon
Maybe the art team can verify?
These are correct. Thanks for taking care of this. :)
Before committing: I'm still not quite sure about the first patch myself, so some advice here would be great. To make my complete lack of coding skills public (still learning ;-) ): I guess it is wrong to replace the icon names in all the instances where gtk_image_set_from_stock is used (cause it simply won't work, as the icon-naming-spec doesn't cover stock icons). So: Am I right that the direct references to specific icon names are just a "bug" in the current code, and the corresponding variables should be used instead. To give an example: gtk_image_set_from_stock (image, "gtk-missing-image", size); should be: gtk_image_set_from_stock (image, GTK_STOCK_MISSING_IMAGE, size); So in the future GTK+ would correctly look up the icon-name from the spec before the included stock-icon. @Hylke: Am I right in my assumptions, essentially in regards to the GTK+ plans?
I've fixed this in git by patching the .desktop file and the GtkBuilder file, since the shell has changed a lot since the original patches. commit 5147efce71b30ee7c15b321bef273daf6fcd3257 Author: Thomas Wood <thomas.wood@intel.com> Date: Fri Jul 16 16:04:11 2010 +0100 shell: use the icon naming specification icon names Fixes bug 616049 - Use correct icon names from the spec