After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615880 - Add some more custom flow returns
Add some more custom flow returns
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-15 19:59 UTC by Sebastian Dröge (slomo)
Modified: 2010-04-16 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pad: add enums for custom flow return success and error codes (3.01 KB, patch)
2010-04-16 13:28 UTC, Tim-Philipp Müller
committed Details | Review

Description Sebastian Dröge (slomo) 2010-04-15 19:59:18 UTC
...as discussed on IRC.

Things like GST_FLOW_CUSTOM_ERROR_1, _2 and GST_FLOW_CUSTOM_OK_1, _2

How many should be added?
Comment 2 Tim-Philipp Müller 2010-04-16 17:01:17 UTC
Committed (with a FIXME 0.11: remove)

commit 126d9cfce8a298f30b10fe304d3fd48ae5c4640c
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Fri Apr 16 14:22:18 2010 +0100

    pad: add enums for custom flow return success and error codes
    
    This way people can just #define their own custom flow returns to
    one of these without having the compiler (esp. gcc-4.5) complain
    about comparing integers to an enum or the enum not being listed
    
    Fixes #615880.
    
    API: GST_FLOW_CUSTOM_SUCCESS_1
    API: GST_FLOW_CUSTOM_SUCCESS_2
    API: GST_FLOW_CUSTOM_ERROR_1
    API: GST_FLOW_CUSTOM_ERROR_2