After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615647 - xvimagesink could miss initial expose
xvimagesink could miss initial expose
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal blocker
: 0.10.29
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-13 13:19 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2010-04-14 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test application to demonstrate the bug (7.92 KB, text/x-csrc)
2010-04-13 13:20 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		  Details
init geometry after setting xid (1.50 KB, patch)
2010-04-13 13:22 UTC, Stefan Sauer (gstreamer, gtkdoc dev) 		committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2010-04-13 13:19:03 UTC 
The recent xvimagesink changes need one fixup. When creating own window size is only checked from event thread anymore. This is racy as the expose can come before setting the xid. Also setting the sink to NULL and PLAYING again would not work, as there is no further expose.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-04-13 13:20:01 UTC 
Created attachment 158601 [details]
test application to demonstrate the bug
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2010-04-13 13:22:09 UTC 
Created attachment 158602 [details] [review]
init geometry after setting xid
Comment 3 Tim-Philipp Müller 2010-04-14 14:33:11 UTC 
Pushed, thanks!

commit 3ec87ee221582ccf7a7f45de611016e840c81643
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Tue Apr 13 16:20:10 2010 +0300

    xvimagesink: init geometry when setting new xid
    
    Don't rely on expose event to query geomentry after new xid is set.
    
    Fixes #615647.