After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615417 - Reversed and one error saturation level in 0.24.0
Reversed and one error saturation level in 0.24.0
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.24.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
fixed-0-24
: 614511 614564 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-04-11 04:24 UTC by Wen-Yen Chuang
Modified: 2010-04-23 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Wen-Yen Chuang 2010-04-11 04:24:36 UTC
In 0.24.0:
1. when saturation is 1, the background image is original image (very light).
2. when saturation is less 1 but near 1, the image is black (dark).
3. the saturation level is reversed compared with vte <= 0.23.5

In 0.23.5 and before:
1. when saturation is near 1, the background image is light.
2. when saturation is near 0, the background image is dark.

The browser I am using has problem to attach the patch, so I paste the very simple patch here:

--- vte-0.24.0.orig/src/vtebg.c
+++ vte-0.24.0/src/vtebg.c
@@ -505,7 +505,7 @@ vte_bg_get_surface(VteBg *bg,
 				       tint->red / 65535.,
 				       tint->green / 65535.,
 				       tint->blue / 65535.,
-				       saturation);
+				       1 - saturation);
 		cairo_set_operator (cr, CAIRO_OPERATOR_OVER);
 		cairo_paint (cr);
 	}

The patch will fix the problem for 0.24.0
Comment 1 Behdad Esfahbod 2010-04-12 15:35:12 UTC
*** Bug 614564 has been marked as a duplicate of this bug. ***
Comment 2 Behdad Esfahbod 2010-04-12 15:35:19 UTC
*** Bug 614511 has been marked as a duplicate of this bug. ***
Comment 3 Behdad Esfahbod 2010-04-12 15:43:28 UTC
Fixed.  Thanks.