After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615294 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: API
3.30.x
Other Linux
: Normal normal
: ---
Assigned To: Matthew Barnes
Srinivasa Ragavan
Depends on: 593671 612509
Blocks: 585391
 
 
Reported: 2010-04-09 14:24 UTC by André Klapper
Modified: 2010-05-19 16:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Partial patch (13.55 KB, patch)
2010-04-15 17:26 UTC, André Klapper
reviewed Details | Review

Description André Klapper 2010-04-09 14:24:40 UTC
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.
Comment 1 André Klapper 2010-04-15 17:26:14 UTC
Created attachment 158826 [details] [review]
Partial patch

Patch that fixes all issues except those that I am too stupid for (3 issues) and those that miss API in gtk+ (4 issues).
Comment 2 Matthew Barnes 2010-04-17 22:55:30 UTC
Grr, didn't notice you had posted a patch until I had already pushed a simliar commit:
http://git.gnome.org/browse/gtkhtml/commit/?id=8d7db0b2135d039ebb969b67bbe05594705844ce

I bumped the GTK+ requirement to 2.20.  Didn't realize we had a solution for GtkAccessible now, so I'll get those hunks committed.  And size_allocate() in gtkhtml.c is doing something insane with GtkLayout children that I need to take a closer look at.
Comment 3 Matthew Barnes 2010-04-17 23:05:33 UTC
Updated status on http://live.gnome.org/Evolution/GTK3.
Comment 4 Milan Crha 2010-04-27 12:10:46 UTC
Matt, I suppose you are on this.
Comment 5 Milan Crha 2010-05-19 11:27:00 UTC
Issue is still there. I'm marking patch as reviewd, because of Matthew's
comment #2. Hopefully Matt will get to this soon.
Comment 6 Matthew Barnes 2010-05-19 13:54:40 UTC
Took a closer look at the GtkLayout issue and the best solution I can think of is instead of chaining up to GtkLayout's size_allocate() method with the children removed, just copy the logic directly into GtkHTML's size_allocate() method and remove the GtkLayoutChild processing loop.  The rest of the logic doesn't seem to be accessing any internal GtkLayout members that we can't get to through its public API.

I'll give this a shot, commit, and see how we do.
Comment 7 Matthew Barnes 2010-05-19 16:06:04 UTC
Fixed in
http://git.gnome.org/browse/gtkhtml/commit/?id=4784f0a6a8fe23957917981152a61b402fa30bde

Seems to work fine for me, further testing is encouraged.