GNOME Bugzilla – Bug 615219
Restarting a song shouldn't be considered a 'Skip'
Last modified: 2012-05-05 21:40:20 UTC
Restarting a song (via Playback > Restart or the 'R' shortcut) increments the Skip Count for that song, which in turn lowers the song's Score. In reality, a restart isn't a skip; if anything, it implies that someone wants to hear the song again, or from the beginning, which doesn't reflect any negative feelings about the song (the opposite, really). Dragging the seek-bar-grabber-thing back to the start doesn't affect Score/Skips, and I would think that the 'Restart' option should behave similarly.
Created attachment 212578 [details] [review] Patch for bug #615219
Comment on attachment 212578 [details] [review] Patch for bug #615219 This patch essentially avoids calling `IncrementLastPlayed`, which in turn bypasses any rating calculation and song skipping.
This is my first patch submitted to banshee as well as my first time writing any C# code. If there's anything I can do to improve this please let me know!
Comment on attachment 212578 [details] [review] Patch for bug #615219 Thanks for the patch, good job ! I've committed it with some changes, to add and use a PlaybackController.Restart () method. Your patch worked as-is, this is just to be consistent with the current API.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.