After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615219 - Restarting a song shouldn't be considered a 'Skip'
Restarting a song shouldn't be considered a 'Skip'
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-04-08 20:11 UTC by Michael Martin-Smucker
Modified: 2012-05-05 21:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for bug #615219 (2.00 KB, patch)
2012-04-22 23:32 UTC, Javon Harper
committed Details | Review

Description Michael Martin-Smucker 2010-04-08 20:11:47 UTC
Restarting a song (via Playback > Restart or the 'R' shortcut) increments the Skip Count for that song, which in turn lowers the song's Score.  In reality, a restart isn't a skip; if anything, it implies that someone wants to hear the song again, or from the beginning, which doesn't reflect any negative feelings about the song (the opposite, really).

Dragging the seek-bar-grabber-thing back to the start doesn't affect Score/Skips, and I would think that the 'Restart' option should behave similarly.
Comment 1 Javon Harper 2012-04-22 23:32:23 UTC
Created attachment 212578 [details] [review]
Patch for bug #615219
Comment 2 Javon Harper 2012-04-22 23:35:18 UTC
Comment on attachment 212578 [details] [review]
Patch for bug #615219 

This patch essentially avoids calling `IncrementLastPlayed`, which in turn bypasses any rating calculation and song skipping.
Comment 3 Javon Harper 2012-04-22 23:59:28 UTC
This is my first patch submitted to banshee as well as my first time writing any C# code. If there's anything I can do to improve this please let me know!
Comment 4 Bertrand Lorentz 2012-05-05 21:40:06 UTC
Comment on attachment 212578 [details] [review]
Patch for bug #615219 

Thanks for the patch, good job !
I've committed it with some changes, to add and use a PlaybackController.Restart () method. Your patch worked as-is, this is just to be consistent with the current API.
Comment 5 Bertrand Lorentz 2012-05-05 21:40:20 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.