After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 615127 - Uses dbus-glib but doesn't check for it
Uses dbus-glib but doesn't check for it
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.30.x
Other GNU Hurd
: Normal major
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2010-04-08 01:00 UTC by Emilio Pozuelo Monfort
Modified: 2010-04-08 08:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build when dbus-glib is not available (1.19 KB, patch)
2010-04-08 07:42 UTC, Josselin Mouette 		none Details | Review

Description Emilio Pozuelo Monfort 2010-04-08 01:00:53 UTC 
Hi,

dlg-package-installer.c unconditionally includes dbus/dbus-glib.h, but configure.ac only checks for dbus-glib-1 if packagekit support is requested. It should check for it always, to avoid build failures like this:

cc -DHAVE_CONFIG_H -I. -I.. -I../copy-n-paste/ -I.. -I.. -DFR_PREFIX=\"/usr\" -DFR_SYSCONFDIR=\"/etc\" -DFR_DATADIR=\"/usr/share\" -DPRIVDATADIR=\"/usr/share/file-roller/\" -DUI_DIR=\"/usr/share/file-roller/ui\" -DFR_LIBDIR=\"/usr/lib\" -DPKG_DATA_DIR=\"/usr/share/file-roller\" -DPIXMAPSDIR=\""/usr/share/pixmaps"\" -DGLADEDIR=\"""\" -DPRIVEXECDIR=\"/usr/lib/file-roller/file-roller/\" -DSHDIR=\"/usr/lib/file-roller/file-roller/\"  -pthread -D_REENTRANT -DORBIT2=1 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include       -g -O2 -g -Wall -O2 -c dlg-package-installer.c
dlg-package-installer.c:28:28: error: dbus/dbus-glib.h: No such file or directory
Comment 1 Josselin Mouette 2010-04-08 07:42:56 UTC 
Created attachment 158176 [details] [review]
Fix build when dbus-glib is not available

It is just missing a pair of #ifdef’s.
Comment 2 Paolo Bacchilega 2010-04-08 08:08:17 UTC 
patch applied, thanks.