After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614995 - Does not compile with -DGSEAL_ENABLE
Does not compile with -DGSEAL_ENABLE
Status: RESOLVED FIXED
Product: dasher
Classification: Applications
Component: gtk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Patrick Welche
Patrick Welche
Depends on:
Blocks: 585391
 
 
Reported: 2010-04-06 18:18 UTC by André Klapper
Modified: 2010-06-03 16:18 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30

Attachments
Partial patch (8.67 KB, patch)
2010-04-06 18:25 UTC, André Klapper 		none Details | Review
Patch fixing nearly all issues (11.54 KB, patch)
2010-04-17 11:30 UTC, André Klapper 		committed Details | Review

Description André Klapper 2010-04-06 18:18:53 UTC 
This module does not build with -DGSEAL_ENABLE.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.
Comment 1 André Klapper 2010-04-06 18:25:00 UTC 
Created attachment 158068 [details] [review]
Partial patch

Partial patch. Note:
gtk_widget_get_window exists since 2.14
gtk_dialog_get_content_area exists since 2.14
gtk_widget_get_realized exists since 2.19.7
so if Dasher is meant to also support older GTK versions then GTK_VERSION_CHECK is needed...
Comment 2 Patrick Welche 2010-04-09 19:19:27 UTC 
This will be fun as in the lab the standard OS is ubuntu 8.04 LTS, which has gtk 2.12.9 - that is why I already have the check for gtk_show_uri() which is quite old. Roll on ubuntu 10.04 LTS...
Comment 3 André Klapper 2010-04-10 18:53:52 UTC 
Just say which GTK version you want to depend on so anything newer can use
#if GTK_CHECK_VERSION(2,14,0)
macro so people could provide patches (if there's some volunteers).
Comment 4 André Klapper 2010-04-14 15:28:54 UTC 
Patrick: Which gtk version is acceptable to depend on for a patch? 2.18 maybe?
Comment 5 Patrick Welche 2010-04-14 17:00:01 UTC 
Is there a hurry for this? (Any chance we can wait until ubuntu 10.04 LTS comes out at the end of the month? + a chance to have time to upgrade to it?)
Comment 6 André Klapper 2010-04-15 06:22:22 UTC 
Not a huge hurry, but the earlier the better as we will find missing accessors in gtk+ by that, and the later in the development cycle the harder it gets.
Waiting for Ubuntu 10.04 sounds okay.
I cross my fingers that dasher does not use some weird GTK+ API. ;-)

Also wondering if simply *all* changes should use #if GTK_CHECK_VERSION so newer versions still run on Maemo4.
Comment 7 André Klapper 2010-04-17 11:30:21 UTC 
Created attachment 158944 [details] [review]
Patch fixing nearly all issues

Patch that fixes everything (without bumping the GTK+ requirement) except for direct access of allocation in Canvas.cpp that I am too stupid for:

  CCanvas::CCanvas(GtkWidget *pCanvas, CPangoCache *pPangoCache)
    : CDasherScreen(pCanvas->allocation.width, pCanvas->allocation.height) {
    m_iWidth = m_pCanvas->allocation.width;
    m_iHeight = m_pCanvas->allocation.height;

Careful review required as I'm quite an idiot when it comes to coding.
Review not urgent - just wanted to make sure that no "weird" GTK API usage takes place in Dasher that requires adding accessors to GTK that don't exist yet).
Comment 9 André Klapper 2010-05-17 14:50:27 UTC 
Thanks! Any plans to fix the remaining issues soon?