GNOME Bugzilla – Bug 614839
Tracker-Plugin: Migrate to Tracker 0.8
Last modified: 2010-04-13 10:53:30 UTC
Created attachment 157923 [details] [review] tracker 0.8 patch The latest stable release of Tracker is version 0.8. The attached patch migrates the Totem local search (tracker) plugin to the new Tracker client API and updates some SPARQL queries.
Broke the API again? Sigh.
The old client API is still available but deprecated. The 0.7.x series was never advertised as stable, as far as I know. But I'm not a Tracker developer and have not used it prior to the 0.8 release.
(In reply to comment #2) > The old client API is still available but deprecated. The 0.7.x series was > never advertised as stable, as far as I know. > > But I'm not a Tracker developer and have not used it prior to the 0.8 release. This is true. I am going to improve the patch slightly, once I get totem building, having several jhbuild issues right now.
Any news on this?
(In reply to comment #4) > Any news on this? It's on my TODO. I have to fix some GTK GSEAL bugs in totem first by the looks of it - at least it was reporting some errors related to that AFAICS last week when I checked.
(In reply to comment #5) > (In reply to comment #4) > > Any news on this? > > It's on my TODO. I have to fix some GTK GSEAL bugs in totem first by the looks > of it - at least it was reporting some errors related to that AFAICS last week > when I checked. It was a two-liner that was fixed on Thursday. Totem compiles fine with deprecations turned on and GTK+ 2.20.0.
I'm willing to improve my patch. Please tell me what needs to be fixed.
Created attachment 158519 [details] [review] Improves previous patch Bastien, let me know if more is needed.
Looks fine apart from: - Shows first 20 results automatically when loaded (without pressing return with empty search entry) Why? The rest looks fine to commit.
(In reply to comment #9) > Looks fine apart from: > - Shows first 20 results automatically when loaded (without pressing > return with empty search entry) > > Why? The rest looks fine to commit. Because showing something instead of nothing initially is more useful to the user and they can reduce those results with specific criteria if they want.
(In reply to comment #10) > (In reply to comment #9) > > Looks fine apart from: > > - Shows first 20 results automatically when loaded (without pressing > > return with empty search entry) > > > > Why? The rest looks fine to commit. > > Because showing something instead of nothing initially is more useful to the > user and they can reduce those results with specific criteria if they want. Right, but doing the search on startup, when the user probably wants to just view a video is not the way it should be done. You should start the search when the sidebar is shown (eg. when the widgets are actually visible), not on startup.
I see, fair point, I can commit the patch without that line for now if you're happy with the rest then.
(In reply to comment #12) > I see, fair point, I can commit the patch without that line for now if you're > happy with the rest then. Yes please.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
(In reply to comment #14) > This problem has been fixed in the development version. The fix will be > available in the next major software release. Thank you for your bug report. Oh, does that mean totem 2.30.1 will not contain this fix? That would be very unfortunate and I'd appreciate if this fix could as be committed to the stable 2.30 branch. Patching the build system is not that much fun
(In reply to comment #15) > (In reply to comment #14) > > This problem has been fixed in the development version. The fix will be > > available in the next major software release. Thank you for your bug report. > > Oh, does that mean totem 2.30.1 will not contain this fix? That would be very > unfortunate and I'd appreciate if this fix could as be committed to the stable > 2.30 branch. Patching the build system is not that much fun I guess Bastien can cherry-pick it if he is happy to do so. I would certainly do it if I was maintainer. For now, it is just in master.