After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614354 - fix small compile break if $(top_srcdir) != $(top_builddir)
fix small compile break if $(top_srcdir) != $(top_builddir)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-30 12:33 UTC by Rob Clark
Modified: 2010-04-04 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix the error (1.24 KB, patch)
2010-03-30 12:35 UTC, Rob Clark 		committed Details | Review

Description Rob Clark 2010-03-30 12:33:38 UTC 
Since there are no src files (or generated Makefile) in gst-libs, you get a compile error if building from a directory other than the src tree:

make[3]: Entering directory `/home/robclark/src/gst-plugins-good/build/gst/videofilter'
  CC     libgstvideoflip_la-gstvideoflip.lo
cc1: error: ../../gst-libs: No such file or directory
Comment 1 Rob Clark 2010-03-30 12:35:46 UTC 
Created attachment 157477 [details] [review]
patch to fix the error
Comment 2 Tim-Philipp Müller 2010-03-30 13:05:50 UTC 
Fixed, thanks for the patch:

commit 25b0a4c91a503a846dd7bd6f710b0636c52e7c5a
Author: Rob Clark <rob@ti.com>
Date:   Tue Mar 30 07:34:07 2010 -0500

    build: fix compiler warning when srcdir != builddir
    
    Fixes '../../gst-libs: No such file or directory' warning/error when
    the build directory is not the same as the source directory.
    
    Fixes #614354.

-ugly also needs fixing from the look of it.
Comment 3 Tim-Philipp Müller 2010-03-30 13:15:41 UTC 
> -ugly also needs fixing from the look of it.

Or not (since it has Makefiles for gst-libs/gst which -good does not have).
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-04-04 19:02:07 UTC 
commit ca0bd3a8cea31f9ea0df798a83d3007e696958ba
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Sun Apr 4 21:36:35 2010 +0300

    configure: fix out of source dir builds
    
    Remove non-existing gst-libs from include and library-paths'.
    Fixes #614354 even more.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2010-04-04 19:16:18 UTC 
I am a bit puzzled. I got the same error as reported and it make sense, as gst-plugins-good had no gst-libs folder at all. Thus my commit. It was happening on two systems. I reverted the fix, still trying to reproduce what happend.