After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 614003 - Can't add new podcasts
Can't add new podcasts
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Podcasting
git master
Other Linux
: Normal major
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-26 11:43 UTC by Iain Lane
Modified: 2010-03-26 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix 614003 by destroying after all the data has been read (2.75 KB, patch)
2010-03-26 11:44 UTC, Iain Lane 		committed Details | Review

Description Iain Lane 2010-03-26 11:43:21 UTC 
Hiya,

When testing my (in progress) code to read proxy settings from GConf, I noticed that I couldn't add new podcast feeds. My analysis showed that this was because the Destroy() call at line 307 of PodcastActions.cs was causing the subsequent attempt to read from the Url field of the dialog to return a null or empty string instead of the URL.

The attached patch fixes the issue for me by destroying after reading from the dialog.

Cheers,
Iain
Comment 1 Iain Lane 2010-03-26 11:44:22 UTC 
Created attachment 157154 [details] [review]
Fix 614003 by destroying after all the data has been read
Comment 2 Gabriel Burt 2010-03-26 17:23:01 UTC 
Review of attachment 157154 [details] [review]:

Thanks Iain for catching this and for the patch - I'm surprised it was working at all for some (most?) people.