After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 613815 - A call in gst/realmedia/rmutils.c discards qualifiers from pointer target type
A call in gst/realmedia/rmutils.c discards qualifiers from pointer target type
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal trivial
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-24 15:22 UTC by LRN
Modified: 2010-03-25 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Casts (const char *) into (gchar *) (968 bytes, patch)
2010-03-24 16:06 UTC, LRN
committed Details | Review

Description LRN 2010-03-24 15:22:42 UTC
rmutils.c: In function 'gst_rm_utils_read_tags':
rmutils.c:105: error: passing argument 5 of 'g_convert_with_fallback' discards qualifiers from pointer target type
f:/gstreamer-buildslave/msys/1.0.11/local/include/glib-2.0/glib/gconvert.h:78: note: expected 'gchar *' but argument is of type 'const char *'

rmutils.c:105 is:
tmp = g_convert_with_fallback (str, -1, "UTF-8", encoding, "*",
          NULL, NULL, NULL);

Suggestion:

tmp = g_convert_with_fallback (str, -1, "UTF-8", encoding, (char *) "*",
          NULL, NULL, NULL);
Comment 1 Sebastian Dröge (slomo) 2010-03-24 15:48:59 UTC
Suggestion is correct ;) If you provide a git format-patch patch I'll push this change
Comment 2 LRN 2010-03-24 16:06:58 UTC
Created attachment 156994 [details] [review]
Casts (const char *) into (gchar *)
Comment 3 Edward Hervey 2010-03-24 18:02:41 UTC
commit 49c5383c7198ddeab84a80f8c96217c826901d83
Author: Руслан Ижбулатов <lrn1986@gmail.com>
Date:   Wed Mar 24 19:07:11 2010 +0300

    Fix pointer type.
    
    Fixes #613815