After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612696 - rtspsrc with tcp timeouts after recent commit
rtspsrc with tcp timeouts after recent commit
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-03-12 13:02 UTC by Luca Ognibene
Modified: 2010-03-15 10:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Luca Ognibene 2010-03-12 13:02:53 UTC 
After this commit: http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=38f2b4735d07554c6243e8bf568ba2cbf7db5803

rtspsrc in tcp mode stops working after 25/30s. If i put this code back it works fine!

- /* see if the timeout period expired */
- if ((tv_timeout.tv_sec | tv_timeout.tv_usec) == 0) {
- GST_DEBUG_OBJECT (src, "timout, sending keep-alive");
- /* send keep-alive, ignore the result, a warning will be posted. */
- gst_rtspsrc_send_keep_alive (src);
- }
Comment 1 Wim Taymans 2010-03-15 10:09:07 UTC 
Is this against gst-rtsp-server?
Comment 2 Luca Ognibene 2010-03-15 10:28:51 UTC 
yes
Comment 3 Wim Taymans 2010-03-15 10:45:01 UTC 
the reason I ask is because there is another bug #612915 about how the quicktime client doesn't send keepalive messages either. So this eventually needs a fix on both the client and the server, I guess.

commit ba6dbaecfc4beb7d9749cb613defcf6c4c05e522
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Mar 15 11:38:23 2010 +0100

    rtspsrc: don't forget to send keepalive messages
    
    When we operate in TCP mode, still send keepalive messages when we
    need to.
    
    Fixes #612696