After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612497 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: gdl
Classification: Other
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: Anjuta maintainers
Anjuta maintainers
Depends on: 612572 622186
Blocks: 585391
 
 
Reported: 2010-03-10 20:42 UTC by André Klapper
Modified: 2010-06-22 16:28 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
Partial patch (6.39 KB, patch)
2010-04-09 10:26 UTC, André Klapper
needs-work Details | Review
Use accessor functions instead direct access. First patch (37.14 KB, patch)
2010-04-21 03:48 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Partial patch (21.50 KB, patch)
2010-06-06 13:31 UTC, André Klapper
committed Details | Review

Description André Klapper 2010-03-10 20:42:41 UTC
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

gdl-dock-object.c: In function ‘gdl_dock_object_real_detach’:
gdl-dock-object.c:363: error: ‘GtkWidget’ has no member named ‘parent’
gdl-dock-object.c:364: error: ‘GtkWidget’ has no member named ‘parent’
gdl-dock-object.c: In function ‘gdl_dock_object_get_parent_object’:
gdl-dock-object.c:498: error: ‘GtkWidget’ has no member named ‘parent’
gdl-dock-object.c:500: error: ‘GtkWidget’ has no member named ‘parent’
make[3]: *** [gdl-dock-object.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/gdl/gdl'
make[2]: *** [all] Error 2
Comment 1 André Klapper 2010-03-13 21:24:06 UTC
Patch in bug 612572 - adding dependency.
Comment 2 André Klapper 2010-04-09 10:26:58 UTC
Created attachment 158269 [details] [review]
Partial patch

gtk+ requirement of this patch is gtk 2.14 only.
Comment 3 Johannes Schmid 2010-04-12 20:56:35 UTC
Review of attachment 158269 [details] [review]:

Thanks! From your comment I guess the bug should be kept open until the rest is fixed?
Comment 4 Johannes Schmid 2010-04-12 21:15:02 UTC
Review of attachment 158269 [details] [review]:

Hmm, actually the patch doesn't apply...
Comment 5 Javier Jardón (IRC: jjardon) 2010-04-21 03:48:17 UTC
Created attachment 159227 [details] [review]
Use accessor functions instead direct access. First patch

This is a first patch. Some work is still needed.

A cleaner solution for GtkButton::in_button is needed:
http://git.gnome.org/browse/gdl/tree/gdl/gdl-dock-item-grip.c#n290
Comment 6 André Klapper 2010-06-03 11:57:14 UTC
Can this patch get a review?
Comment 7 Johannes Schmid 2010-06-03 12:30:40 UTC
Sorry, as Javier said "first patch" I assumed there would be a follow-up anyway. Do we have a solution for GtkButton::in_button? Otherwise seems fine.
Comment 8 André Klapper 2010-06-04 14:45:44 UTC
(In reply to comment #7)
> Do we have a solution for GtkButton::in_button? Otherwise seems fine.

Johannes, was that a hidden "accepted_commit-now"? ;-)
Comment 9 Johannes Schmid 2010-06-04 14:56:39 UTC
Review of attachment 159227 [details] [review]:

Still not sure about the button thing.
Comment 10 Javier Jardón (IRC: jjardon) 2010-06-06 03:56:09 UTC
Comment on attachment 159227 [details] [review]
Use accessor functions instead direct access. First patch

Andre, I've committed your patch for you, hope you dont mind ;)

commit fef8d6d96091320917b6ee59c79012f7de3636bf
Comment 11 André Klapper 2010-06-06 13:31:49 UTC
Created attachment 162864 [details] [review]
Partial patch

Another partial patch
Comment 12 Johannes Schmid 2010-06-06 15:00:28 UTC
Review of attachment 162864 [details] [review]:

Looks good! What's still missing?
Comment 13 André Klapper 2010-06-06 15:51:21 UTC
Comment on attachment 162864 [details] [review]
Partial patch

Committed as http://git.gnome.org/browse/gdl/commit/?id=aee676e13dc344cc80800d2682737c43a459e11b .
List of what is still missing is too long to post it here - anybody feel free to compile with -DGSEAL_ENABLE...
Comment 14 André Klapper 2010-06-21 07:25:03 UTC
Complete list of what is left and needs to be fixed within the next days:

gdl/gdl-dock.c: In function ‘gdl_dock_size_request’:
gdl-dock.c:564: error: ‘GtkWidget’ has no member named ‘requisition’
gdl/gdl-dock-item.c: In function ‘gdl_dock_item_size_request’:
gdl-dock-item.c:789: error: ‘GtkWidget’ has no member named ‘requisition’
gdl/gdl-dock-item-grip.c: In function ‘gdl_dock_item_grip_iconify_clicked’:
gdl-dock-item-grip.c:295: error: ‘GtkButton’ has no member named ‘in_button’
gdl/gdl-dock-tablabel.c: In function ‘gdl_dock_tablabel_size_request’:
gdl-dock-tablabel.c:308: error: ‘GtkWidget’ has no member named ‘requisition’
gdl/gdl-dock-tablabel.c: In function ‘gdl_dock_tablabel_realize’:
gdl-dock-tablabel.c:564: error: ‘GtkWidget’ has no member named ‘style’
gdl-dock-tablabel.c:564: error: ‘GtkWidget’ has no member named ‘style’
gdl-dock-tablabel.c:564: error: ‘GtkWidget’ has no member named ‘window’
gdl/gdl-dock-bar.c: In function ‘gdl_dock_bar_size_vallocate’:
gdl-dock-bar.c:530: error: ‘GtkWidget’ has no member named ‘allocation’
gdl-dock-bar.c:562: error: ‘GtkWidget’ has no member named ‘requisition’
gdl/gdl-dock-bar.c: In function ‘gdl_dock_bar_size_hallocate’:
gdl-dock-bar.c:762: error: ‘GtkWidget’ has no member named ‘allocation’
gdl-dock-bar.c:796: error: ‘GtkWidget’ has no member named ‘requisition’
gdl/gdl-switcher.c: In function ‘layout_buttons’:
gdl-switcher.c:259: error: ‘GtkWidget’ has no member named ‘allocation’
gdl/gdl-switcher.c: In function ‘do_layout’:
gdl-switcher.c:434: error: ‘GtkWidget’ has no member named ‘allocation’
gdl/gdl-switcher.c: In function ‘gdl_switcher_size_allocate’:
gdl-switcher.c:539: error: ‘GtkWidget’ has no member named ‘allocation’
gdl/test-dock.c: In function ‘save_layout_cb’:
test-dock.c:159: error: ‘GtkDialog’ has no member named ‘vbox’
Comment 15 Johannes Schmid 2010-06-21 07:30:19 UTC
I worked on this yesterday but then realized that the patch from comment #11 broke gdl completely. Will have to revert that and fix the remaining things. It's nothing really difficult but I didn't find out where the former patch broke things exactly.
Comment 16 André Klapper 2010-06-21 07:45:36 UTC
(In reply to comment #15)
> broke gdl completely.

Uhm. What does that mean exactly?
Comment 17 Johannes Schmid 2010-06-21 08:02:26 UTC
@Andre: simply try the gdl/test-dock application - you will end up with an infinite loop of Gtk-Criticals...
Comment 18 Johannes Schmid 2010-06-22 15:53:24 UTC
Review of attachment 159227 [details] [review]:

@Andre: Be more careful next time
@me: better review needed...

::: gdl/gdl-dock-object.c
@@ +362,3 @@
     widget = GTK_WIDGET (object);
+    if (gtk_widget_get_parent (widget))
+        gtk_container_remove (GTK_CONTAINER (gtk_widget_get_parent (GTK_WIDGET (parent))), widget);

This should be gtk_widget_get_parent (GTK_WIDGET (parent)) and it's the reason this patch breaks things.

Fixed...
Comment 19 André Klapper 2010-06-22 16:26:29 UTC
Sorry - happens when doing such boring work for hours. :-/
Comment 20 Johannes Schmid 2010-06-22 16:28:07 UTC
Fixed remaing things in head:
http://git.gnome.org/browse/gdl/commit/?id=b3eecbce1e85e1d19da4250f8550a69f09c68cbe