After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612493 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: nautilus-sendto
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: nautilus-sendto-maint
nautilus-sendto-maint
: 613990 (view as bug list)
Depends on: 616182
Blocks: 585391
 
 
Reported: 2010-03-10 20:39 UTC by André Klapper
Modified: 2010-06-08 17:35 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Use accessor functions instead direct access (1.96 KB, patch)
2010-03-12 02:53 UTC, Javier Jardón (IRC: jjardon)
needs-work Details | Review

Description André Klapper 2010-03-10 20:39:46 UTC
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

e-contact-entry.c: In function ‘entry_changed_cb’:
e-contact-entry.c:388: error: ‘GtkEntry’ has no member named ‘text_length’
make[5]: *** [e-contact-entry.lo] Error 1
make[5]: Leaving directory `/home/andre/svn-gnome/nautilus-sendto/src/plugins/evolution'
make[4]: *** [all] Error 2
Comment 1 Javier Jardón (IRC: jjardon) 2010-03-12 02:53:49 UTC
Created attachment 155919 [details] [review]
Use accessor functions instead direct access
Comment 2 André Klapper 2010-04-18 20:48:48 UTC
*ping*
Can this please get a review/commit?
Comment 3 Bastien Nocera 2010-04-19 13:43:26 UTC
Review of attachment 155919 [details] [review]:

Changes to e-contact-entry need to be done in contact-lookup-applet first, and propagated to nautilus-sendto.
Comment 4 André Klapper 2010-04-23 17:40:41 UTC
So can this get in now, or what is blocking this?
Comment 5 André Klapper 2010-05-28 15:22:23 UTC
hadess: Can this get in now?
Comment 6 Bastien Nocera 2010-05-28 15:52:02 UTC
(In reply to comment #5)
> hadess: Can this get in now?

Nobody mentioned specifically that the contact-lookup-applet changes were made. Just need to separate the patch in 2 now, and it would be fine to commit.
Comment 7 André Klapper 2010-05-29 01:43:24 UTC
Comment on attachment 155919 [details] [review]
Use accessor functions instead direct access

> Just need to separate the patch in 2 now, and it would be fine to commit.

Done in 2d140007d1b9b541d922ceda04439c17bce70fd9 and 6d9294461935516991082e535a09b28d27105abe
Comment 8 Bastien Nocera 2010-06-08 17:35:26 UTC
*** Bug 613990 has been marked as a duplicate of this bug. ***