GNOME Bugzilla – Bug 612491
Does not compile with -DGSEAL_ENABLED
Last modified: 2012-01-12 16:18:53 UTC
This module does not build with -DGSEAL_ENABLED. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. metacity-window-demo.c: In function ‘on_realize_set_struts’: metacity-window-demo.c:70: error: ‘GtkObject’ has no member named ‘flags’ metacity-window-demo.c:77: error: ‘GtkWidget’ has no member named ‘window’ metacity-window-demo.c: In function ‘set_gtk_window_struts’: metacity-window-demo.c:106: error: ‘GtkObject’ has no member named ‘flags’ metacity-window-demo.c:107: error: ‘GtkWidget’ has no member named ‘window’ metacity-window-demo.c: In function ‘on_realize_set_type’: metacity-window-demo.c:134: error: ‘GtkObject’ has no member named ‘flags’ metacity-window-demo.c:140: error: ‘GtkWidget’ has no member named ‘window’ metacity-window-demo.c: In function ‘set_gtk_window_type’: metacity-window-demo.c:159: error: ‘GtkObject’ has no member named ‘flags’ metacity-window-demo.c:160: error: ‘GtkWidget’ has no member named ‘window’ metacity-window-demo.c: In function ‘on_realize_set_border_only’: metacity-window-demo.c:174: error: ‘GtkObject’ has no member named ‘flags’ metacity-window-demo.c:176: error: ‘GtkWidget’ has no member named ‘window’ metacity-window-demo.c: In function ‘set_gtk_window_border_only’: metacity-window-demo.c:191: error: ‘GtkObject’ has no member named ‘flags’ metacity-window-demo.c:192: error: ‘GtkWidget’ has no member named ‘window’ make[4]: *** [metacity-window-demo.o] Error 1 make[4]: Leaving directory `/home/andre/svn-gnome/metacity/src/tools' make[3]: *** [all-recursive] Error 1
ping - anybody planning to work on this?
Created attachment 160749 [details] [review] Patch for METACITY_WINDOW_DEMO Bumps gtk+ requirement to 2.19.7 because of gtk_widget_get_realized
ping - can I get a patch review?
Created attachment 163269 [details] [review] Partial Patch Needs gtk 2.20 because of gtk_widget_get_realized, rest is 2.18.
Looking good: committed. Sorry for the delay.
Review of attachment 163269 [details] [review]: Looks good. Committed.
Review of attachment 160749 [details] [review]: Looks good. Committed.
Thanks! Reopening as there's more work to do until it compiles.
Created attachment 163604 [details] [review] [GSEAL] Build with GSEAL enabled Add missing parts - patch needs gdk_visual_get_depth() from current development version.
Created attachment 163605 [details] [review] Add compatibility with GTK+ 2.20 Add a compatibility macro for gdk_visual_get_depth().
Last patch also attached to bug 572332 (in case someone wonders why there are two more defines in gdk-compat.h)
Review of attachment 163604 [details] [review]: (Just to say that this is next on my list to review, but it's more than I can fit in the remaining time this morning)
Created attachment 165963 [details] [review] [GSEAL] Build with GSEAL enabled Rebased to master / removed version bump from configure.in
Comment on attachment 163605 [details] [review] Add compatibility with GTK+ 2.20 Marking attachment 163605 [details] [review] obsolete in favor of the version attached to bug 572332.
I think that we can close this bug as fixed now that nautilus depend on GTK+3, rigth?
(In reply to comment #15) > I think that we can close this bug as fixed now that nautilus depend on GTK+3, > rigth? Wrong bug? Metacity still depends on GTK+-2 ...
Sorry Florian, Anyway, What is the status of this? Seems that this is the latest GNOME module that still doesnt compile with -DGSEAL_ENABLED
I didn't update those metacity patches since July, so all deprecations since then are not handled (notably, this was before the Benjamin's drawing stuff landed) - so it's horribly outdated. It should not be too hard to pick out the corresponding mutter patches and port them, but given that UI freeze is approaching in shell land, I won't have time to do it.
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]
Created attachment 188513 [details] [review] build: Use accessor functions Direct struct access has been deprecated, so use the appropriate replacements to build with GSEAL enabled.
Would be nice to not let it bitrot again ... *hint, hint*
Florian: Assuming that Metacity is unmaintained, I vote for just committing this.
Attachment 188513 [details] pushed as 63834e0 - build: Use accessor functions (In reply to comment #22) > Florian: Assuming that Metacity is unmaintained, I vote for just committing > this. Sure, though the point of GSEAL (as I understand it) was to prepare for a GTK+-3 port, which is unlikely to happen for metacity at this point ...