After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612489 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-10 20:36 UTC by André Klapper
Modified: 2010-03-10 22:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Description André Klapper 2010-03-10 20:36:57 UTC 
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

test-display.c: In function ‘view_pixbuf’:
test-display.c:634: error: ‘GtkWidget’ has no member named ‘window’
test-display.c:635: error: ‘GtkWidget’ has no member named ‘window’
test-display.c:636: error: ‘GtkWidget’ has no member named ‘window’
test-display.c:636: error: ‘GtkWidget’ has no member named ‘window’
make[2]: *** [test-display.o] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/librsvg'
Comment 1 André Klapper 2010-03-10 21:51:15 UTC 
Totally uneducated guess:

--- a/test-display.c
+++ b/test-display.c
@@ -631,9 +631,9 @@ view_pixbuf (ViewerCbInfo * info, int xid, const char *color)
 
 #ifdef ENABLE_XEMBED
     if (xid > 0) {
-        XReparentWindow (GDK_WINDOW_XDISPLAY (win->window),
-                         GDK_WINDOW_XID (win->window), xid, 0, 0);
-        XMapWindow (GDK_WINDOW_XDISPLAY (win->window), GDK_WINDOW_XID (win->window));
+        XReparentWindow (GDK_WINDOW_XDISPLAY (gtk_widget_get_window(win)),
+                         GDK_WINDOW_XID (gtk_widget_get_window(win)), xid, 0, 0);
+        XMapWindow (GDK_WINDOW_XDISPLAY (gtk_widget_get_window(win)), GDK_WINDOW_XID (gtk_widget_get_window(win)));
     }
 #endif
 }


gtk+-2.0 >= 2.16.0 required already, and gtk_widget_get_window() exists since 2.14. Compiles fine after applying.
Comment 2 Thomas Andersen 2010-03-10 22:36:49 UTC 
the patch looks correct to me