After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612486 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: gtk-engines
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-engines maintainers
gtk-engines maintainers
: 623275 (view as bug list)
Depends on: 621250
Blocks: 585391
 
 
Reported: 2010-03-10 20:34 UTC by André Klapper
Modified: 2010-07-02 16:59 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
Partial patch (14.33 KB, patch)
2010-04-12 20:07 UTC, André Klapper
none Details | Review
Initial patch (15.86 KB, patch)
2010-06-06 16:45 UTC, André Klapper
rejected Details | Review
Second patch (16.66 KB, patch)
2010-06-07 17:56 UTC, André Klapper
rejected Details | Review

Description André Klapper 2010-03-10 20:34:27 UTC
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

./widget-information.c: In function ‘ge_check_hint’:
./widget-information.c:129: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:129: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:133: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:134: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:134: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:135: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:137: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:137: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:149: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:182: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_is_combo_box_entry’:
./widget-information.c:222: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:224: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:224: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:227: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_is_combo_box’:
./widget-information.c:248: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:250: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:250: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:253: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:255: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:258: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_is_combo’:
./widget-information.c:268: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:270: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:270: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:273: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_is_toolbar_item’:
./widget-information.c:289: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:290: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:290: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:291: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:291: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:292: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:292: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:293: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:293: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:294: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:294: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:297: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_is_panel_widget_item’:
./widget-information.c:307: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:309: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:309: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:309: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:312: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_is_bonobo_dock_item’:
./widget-information.c:324: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:324: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:326: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:326: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c:328: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_find_combo_box_entry_widget’:
./widget-information.c:359: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_find_combo_box_widget’:
./widget-information.c:380: error: ‘GtkWidget’ has no member named ‘parent’
./widget-information.c: In function ‘ge_find_combo_widget’:
./widget-information.c:395: error: ‘GtkWidget’ has no member named ‘parent’
make[3]: *** [widget-information.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/gtk-engines/engines/support'
make[2]: *** [all] Error 2
Comment 1 André Klapper 2010-04-12 20:07:38 UTC
Created attachment 158531 [details] [review]
Partial patch

Partial patch to start with, fixing a few issues and bumping gtk+ requirement to 2.14 (rest is ifdef'ed in the code).
Comment 2 André Klapper 2010-05-21 11:48:20 UTC
ping?
Comment 3 Benjamin Berg 2010-06-05 14:43:52 UTC
Sorry for the late response. I think we can safely increase the required GTK+ version to 2.14. I guess we can also increase it to 2.18. Everyone that needs to run older GTK+ version can just stick with an older gtk-engines 2.20 release.

Though gtk-engines should probably be branched for 2.22 (GNOME 2.30) before doing a dependency change.
Comment 4 André Klapper 2010-06-06 16:45:39 UTC
Created attachment 162872 [details] [review]
Initial patch

I prefer to bump gtk+ to 2.18 because of all the GtkAllocation stuff.
Comment 5 André Klapper 2010-06-07 17:56:32 UTC
Created attachment 162959 [details] [review]
Second patch

Second patch (requires the first to be adapted) fixing a few more trivial issues.
Still lots of work left that should be done by people that actually have a clue. :-P
Comment 6 Bastien Nocera 2010-06-10 18:00:10 UTC
Why o why. This is all already done in the gnome3 branch. It just needs merging into master.
Comment 7 André Klapper 2010-06-10 18:45:02 UTC
(In reply to comment #6)
> Why o why. This is all already done in the gnome3 branch.

Would have been cool to know this earlier, e.g. by a comment on this ticket. :)

But anyway, happy to hear that this has been done already!
Then let's wait for merging (hopefully before 2.31.4).
Comment 8 Bastien Nocera 2010-06-10 19:24:00 UTC
gtk-engines-2.90.0 is out.
Comment 9 Benjamin Berg 2010-06-10 20:07:33 UTC
André, what about a gtk-engines version for GTK+ 2.22? We might still want to have this, would it be worth to backport the fixes?
Comment 10 Bastien Nocera 2010-06-10 21:24:49 UTC
Turns out that, contrary to my belief, gtk+ 3.0 doesn't GSEAL enabled by default.

We're missing some API.
Comment 11 Federico Mena Quintero 2010-06-22 19:03:58 UTC
What API is missing?
Comment 12 André Klapper 2010-06-22 19:17:40 UTC
See the "Depends on" section of this report: bug 621250
Comment 13 André Klapper 2010-06-28 14:52:29 UTC
Any plans to fix this for today's release, now that bug 621250 is fixed?
Comment 14 Koop Mast (kwm) 2010-06-30 06:45:18 UTC
Gtk-engines 2.90.3.1 builds fine with gtk 2.90.4. 

But it seems animation support in clearlooks (--enable-animation). was missed. It fails with the following error:

  CC     clearlooks_style.lo
./src/clearlooks_style.c: In function 'clearlooks_style_draw_box':
./src/clearlooks_style.c:761: error: 'GtkWidget' has no member named 'allocation'
./src/clearlooks_style.c:761: error: 'GtkWidget' has no member named 'allocation'
./src/clearlooks_style.c:763: error: 'GtkProgressBar' has no member named 'activity_mode'
./src/clearlooks_style.c:778:2: warning: #warning Assuming non-pulsing progress bars because there is currently no way to query them in GTK+ 3.0.
gmake[2]: *** [clearlooks_style.lo] Error 1
Comment 15 Benjamin Berg 2010-07-02 16:58:07 UTC
*** Bug 623275 has been marked as a duplicate of this bug. ***
Comment 16 Benjamin Berg 2010-07-02 16:59:21 UTC
Ok, fixed.