After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612479 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: gnome-media
Classification: Deprecated
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gnome media maintainers
gnome media maintainers
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-10 20:28 UTC by André Klapper
Modified: 2010-06-06 15:39 UTC
See Also:
GNOME target: 3.0
GNOME version: 2.29/2.30


Attachments
gnome-volume-control: compile with GSEAL (9.01 KB, text/plain)
2010-03-10 23:24 UTC, Marc-Andre Lureau
  Details
profiles: compile with GSEAL (2.16 KB, patch)
2010-03-10 23:43 UTC, Marc-Andre Lureau
none Details | Review
gnome-volume-control: compile with GSEAL (9.01 KB, patch)
2010-03-10 23:43 UTC, Marc-Andre Lureau
none Details | Review
grecord: compile with GSEAL (4.60 KB, patch)
2010-03-10 23:44 UTC, Marc-Andre Lureau
none Details | Review
gst-mixer: compile with GSEAL (4.85 KB, patch)
2010-03-10 23:54 UTC, Marc-Andre Lureau
none Details | Review

Description André Klapper 2010-03-10 20:28:20 UTC
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

audio-profiles-edit.c: In function ‘gm_audio_profiles_edit_init’:
audio-profiles-edit.c:601: error: ‘GtkDialog’ has no member named ‘vbox’
audio-profiles-edit.c:602: error: ‘GtkDialog’ has no member named ‘action_area’
audio-profiles-edit.c:603: error: ‘GtkDialog’ has no member named ‘action_area’
audio-profiles-edit.c:617: error: ‘GtkDialog’ has no member named ‘vbox’
make[3]: *** [libgnome_media_profiles_la-audio-profiles-edit.lo] Error 1
make[3]: Leaving directory `/home/andre/svn-gnome/gnome-media/profiles'
make[2]: *** [all-recursive] Error 1
Comment 1 Marc-Andre Lureau 2010-03-10 23:24:32 UTC
Created attachment 155800 [details]
gnome-volume-control: compile with GSEAL
Comment 2 Marc-Andre Lureau 2010-03-10 23:43:35 UTC
Created attachment 155804 [details] [review]
profiles: compile with GSEAL
Comment 3 Marc-Andre Lureau 2010-03-10 23:43:47 UTC
Created attachment 155805 [details] [review]
gnome-volume-control: compile with GSEAL
Comment 4 Marc-Andre Lureau 2010-03-10 23:44:19 UTC
Created attachment 155806 [details] [review]
grecord: compile with GSEAL
Comment 5 Marc-Andre Lureau 2010-03-10 23:54:48 UTC
Created attachment 155808 [details] [review]
gst-mixer: compile with GSEAL
Comment 6 André Klapper 2010-04-23 16:40:07 UTC
+++ b/profiles/audio-profiles-edit.c
+  gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_content_area (gdialog)), 2); /* 2 * 5 + 2 = 12 */
+  gtk_container_set_border_width (GTK_CONTAINER (gtk_dialog_get_action_area (gdialog)), 5);
+  gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_action_area (gdialog)), 6);

I'm not at all a developer, but wouldn't it make to store this in a variable as it's called several times?

+++ b/gnome-volume-control/src/gvc-level-bar.c
-        widget->allocation = *allocation;
+        gtk_widget_set_allocation (widget, allocation);
+        gtk_widget_get_allocation (widget, allocation);

Shouldn't that be gtk_widget_get_allocation (widget, &allocation); ?
Comment 7 André Klapper 2010-05-29 01:49:08 UTC
ping?
Comment 8 Marc-Andre Lureau 2010-06-06 13:00:16 UTC
(In reply to comment #6)
> +++ b/profiles/audio-profiles-edit.c
> +  gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_content_area (gdialog)), 2); /*
> 2 * 5 + 2 = 12 */
> +  gtk_container_set_border_width (GTK_CONTAINER (gtk_dialog_get_action_area
> (gdialog)), 5);
> +  gtk_box_set_spacing (GTK_BOX (gtk_dialog_get_action_area (gdialog)), 6);
> 
> I'm not at all a developer, but wouldn't it make to store this in a variable as
> it's called several times?
> 

it's not time critical, you save only one function call..

> +++ b/gnome-volume-control/src/gvc-level-bar.c
> -        widget->allocation = *allocation;
> +        gtk_widget_set_allocation (widget, allocation);
> +        gtk_widget_get_allocation (widget, allocation);
> 
> Shouldn't that be gtk_widget_get_allocation (widget, &allocation); ?

no, it's both  GtkAllocation *allocation.


make CFLAGS+="-DGSEAL_ENABLE" still works, but I have only 2.20.

Can somebody check it still compiles with latest gtk?
Comment 9 André Klapper 2010-06-06 15:18:32 UTC
With gtk+ git master (2.21.2) and -DGSEAL_ENABLE gnome-media builds fine here.
Thanks for your work! Feel free to close for now...
Comment 10 Marc-Andre Lureau 2010-06-06 15:39:54 UTC
merci andre!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.