GNOME Bugzilla – Bug 612473
Does not compile with -DGSEAL_ENABLED
Last modified: 2010-04-23 15:19:13 UTC
This module does not build with -DGSEAL_ENABLED. See http://live.gnome.org/GnomeGoals/UseGseal . Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing. Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status. The jhbuild output posted here of course only lists the very first error when trying to compile. charpick.c: In function ‘get_menu_pos’: charpick.c:345: error: ‘GtkWidget’ has no member named ‘window’ charpick.c:346: error: ‘GtkWidget’ has no member named ‘window’ charpick.c: In function ‘chooser_button_clicked’: charpick.c:372: error: ‘GtkObject’ has no member named ‘flags’ make[3]: *** [charpick.o] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/gnome-applets/charpick' make[2]: *** [all-recursive] Error 1
Created attachment 155836 [details] [review] Fix for charpick bumps gtk+ requirement to 2.19.7
Comment on attachment 155836 [details] [review] Fix for charpick Charpick FIXED and committed: http://git.gnome.org/browse/gnome-applets/commit/?id=551d6dd3e388a0d8ab49fda35cac5eb5db54b528
Next one to do is Disk Mounter. Volunteers welcome. drive-button.c: In function ‘position_menu’: drive-button.c:185: error: ‘GtkWidget’ has no member named ‘requisition’ drive-button.c:186: error: ‘GtkWidget’ has no member named ‘requisition’ drive-button.c:189: error: ‘GtkWidget’ has no member named ‘window’ drive-button.c:193: error: ‘GtkWidget’ has no member named ‘window’ drive-button.c:198: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c:199: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c:202: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c:204: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c:205: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c:208: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c:209: error: ‘GtkWidget’ has no member named ‘allocation’ drive-button.c: In function ‘drive_button_update’: drive-button.c:326: error: ‘GtkBin’ has no member named ‘child’ drive-button.c:327: error: ‘GtkBin’ has no member named ‘child’ drive-button.c:361: error: ‘GtkBin’ has no member named ‘child’ drive-button.c:387: error: ‘GtkBin’ has no member named ‘child’ make[3]: *** [drive-button.o] Error 1 make[3]: Leaving directory `/home/andre/svn-gnome/gnome-applets/drivemount' make[2]: *** [all-recursive] Error 1
Created attachment 159372 [details] [review] Patch fixing all remaining Sealing issues
Created attachment 159373 [details] [review] Cleanup patch for GTK_CHECK_VERSION To apply after "Patch fixing all remaining Sealing issues"
Review of attachment 159372 [details] [review]: I inlined some comments; apart from this, the patch looks good to me. ::: accessx-status/applet.c @@ +626,3 @@ latched_mods = event->state.latched_mods; } + else if (sapplet->applet && gtk_widget_get_window (GTK_WIDGET (sapplet->applet))) { As you use three times gtk_widget_get_window() inside the same function, it's probably better to have a GtkWindow * window; window = gtk_widget_get_window (GTK_WIDGET (sapplet->applet)); snippet here. @@ +989,2 @@ if (GTK_WIDGET_REALIZED (sapplet->box) && +#endif As you're already bumping the GTK+ requirement I'd rather depend on GTK+ >= 2.20 in configure.in than having #ifdefs around in the codebase. ::: battstat/battstat_applet.c @@ +754,3 @@ { gtk_widget_realize( battstat->applet ); + battstat->pixgc = gdk_gc_new( gtk_widget_get_window (battstat->applet) ); Also here, it seems a good idea to save the pointer to the window and use it later.
Heja Cosimo, thanks a bunch for the review! Pushed with the first two comments and branched for gnome-2-30. I'm not convinced in the last case as the first calls are in if{} and the third call in an else{}, but feel free to correct me. :)