After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612471 - Does not compile with -DGSEAL_ENABLED
Does not compile with -DGSEAL_ENABLED
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks: 585391
 
 
Reported: 2010-03-10 20:22 UTC by André Klapper
Modified: 2010-04-13 12:11 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30

Attachments
Use accessor functions (12.66 KB, patch)
2010-04-06 17:26 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Use accessor functions.v2 (13.01 KB, patch)
2010-04-06 18:33 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description André Klapper 2010-03-10 20:22:28 UTC 
This module does not build with -DGSEAL_ENABLED.
See http://live.gnome.org/GnomeGoals/UseGseal .

Note that maybe this report cannot be fixed yet, as GTK+ still misses some accessor functions (see bug 588389, bug 597610) needed for sealing.
Also see http://live.gnome.org/GTK%2B/3.0/PendingSealings for current status.

The jhbuild output posted here of course only lists the very first error when trying to compile.

gconf-bookmarks.c: In function "gconf_bookmarks_set_have_icons":
gconf-bookmarks.c:64: error: "GtkMenuShell" has no member named "children"
make[2]: *** [gconf-bookmarks.o] Error 1
make[2]: Leaving directory `/home/andre/svn-gnome/gconf-editor/src'
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-06 17:26:40 UTC 
Created attachment 158061 [details] [review]
Use accessor functions
Comment 2 Cosimo Cecchi 2010-04-06 17:48:32 UTC 
Review of attachment 158061 [details] [review]:

Hi, this looks mostly fine. Did you test everything still works as expected?

::: src/gconf-cell-renderer.c
@@ +217,3 @@
 	GConfValue *value;
+
+	g_object_get (entry, "editing-canceled", &editing_canceled, NULL);

It seems this property has been introduced with GTK+ 2.20. If so, please require an appropriate version of GTK+ in the configure script.
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-06 18:33:37 UTC 
Created attachment 158070 [details] [review]
Use accessor functions.v2

Ops, sorry, here the patch changing the GTK required version.

I've tested the program here are all seems to work fine.
Comment 4 Cosimo Cecchi 2010-04-06 19:17:21 UTC 
Review of attachment 158070 [details] [review]:

Looks good, please commit to master.
Comment 5 Cosimo Cecchi 2010-04-13 12:11:37 UTC 
Pushed.