GNOME Bugzilla – Bug 612410
[API][tags] add new geo tags
Last modified: 2010-03-11 19:04:27 UTC
The following patch adds tags: *_GEO_LOCATION_COUNTRY *_GEO_LOCATION_CITY *_GEO_LOCATION_SUBLOCATION Those are useful to specify where a media has been taken/created/produced.
Created attachment 155726 [details] [review] tags: Adds new geo location tags Adds new tags GST_TAG_GEO_LOCATION_COUNTRY, GST_TAG_GEO_LOCATION_CITY and GST_TAG_GEO_LOCATION_SUBLOCATION.
Created attachment 155840 [details] [review] tags: Adds new geo location tags Adds new tags GST_TAG_GEO_LOCATION_COUNTRY, GST_TAG_GEO_LOCATION_CITY and GST_TAG_GEO_LOCATION_SUBLOCATION. API: GST_TAG_GEO_LOCATION_COUNTRY, GST_TAG_GEO_LOCATION_CITY, GST_TAG_GEO_LOCATION_SUBLOCATION
Looks ok to me (the sublocation bit isn't very nice, but if this is how it's handled in e.g. XMP so be it... and this also seemed to be the consensus on IRC) - please add "(string)" bits to the gtk-doc chunks for the new tags, for consistency :) - might want to mention XMP in the gtk-doc chunk for sublocation (dunno)
Created attachment 155849 [details] [review] tags: Adds new geo location tags Updated according to Tim's comments
Created attachment 155850 [details] [review] metadata: Remove _XMP_GEO_* tags Removes GST_TAG_XMP_GEO_LOCATION_COUNTRY, GST_TAG_XMP_GEO_LOCATION_CITY and GST_TAG_XMP_GEO_LOCATION_SUBLOCATION from metadata's private tags as those are now present at -core tags. Fixes #612410
> Created an attachment (id=155850) [details] [review] > metadata: Remove _XMP_GEO_* tags Should also bump the GST_REQ in configure.ac. to git then (0.10.28.1)
Created attachment 155858 [details] [review] metadata: Remove _XMP_GEO_* tags Updated version that bumps requirements for core
Fixed. Module: gstreamer Branch: master Commit: f563ac57f8155cea2449297647e31244540fdd29 URL: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=f563ac57f8155cea2449297647e31244540fdd29 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Tue Mar 9 20:38:47 2010 -0300 tags: Adds new geo location tags Adds new tags GST_TAG_GEO_LOCATION_COUNTRY, GST_TAG_GEO_LOCATION_CITY and GST_TAG_GEO_LOCATION_SUBLOCATION. API: GST_TAG_GEO_LOCATION_COUNTRY API: GST_TAG_GEO_LOCATION_CITY API: GST_TAG_GEO_LOCATION_SUBLOCATION Fixes #612410 Module: gst-plugins-bad Branch: master Commit: c5034a716dc10e9d631d2b447faad2089a432284 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=c5034a716dc10e9d631d2b447faad2089a432284 Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk> Date: Thu Mar 11 09:29:53 2010 -0300 metadata: Remove _XMP_GEO_* tags Removes GST_TAG_XMP_GEO_LOCATION_COUNTRY, GST_TAG_XMP_GEO_LOCATION_CITY and GST_TAG_XMP_GEO_LOCATION_SUBLOCATION from metadata's private tags as those are now present at -core tags. Fixes #612410