After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 612352 - Migrate API docs from templates to source files (GtkBox)
Migrate API docs from templates to source files (GtkBox)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 599599
 
 
Reported: 2010-03-09 22:55 UTC by Tadej Borovšak
Modified: 2010-04-28 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that migrates API docs. (12.64 KB, patch)
2010-03-09 22:55 UTC, Tadej Borovšak 		needs-work Details | Review
Updated patch (11.68 KB, patch)
2010-04-28 09:35 UTC, Tadej Borovšak 		committed Details | Review

Description Tadej Borovšak 2010-03-09 22:55:13 UTC 
Created attachment 155690 [details] [review]
Patch that migrates API docs.

Migrate GtkBox API docs into source files.
Comment 1 Javier Jardón (IRC: jjardon) 2010-04-28 01:17:56 UTC 
Review of attachment 155690 [details] [review]:

Patch looks good, only twor little comments:

::: gtk/gtkbox.c
@@ +58,3 @@
+ * </varlistentry>
+ *
+ * </variablelist>

As mclasen said here: https://bugzilla.gnome.org/show_bug.cgi?id=597865#c45

"I prefer to do 'see also' as a simple list of links, instead of an explicit varlist."

::: gtk/gtkbox.h
@@ +88,3 @@
+ * and reset the <structfield>padding</structfield>,
+ * <structfield>expand</structfield>, <structfield>fill</structfield>,
+ * and <structfield>pack</structfield> fields.

You can use the #GtkBoxChild.pack syntax here
Comment 2 Tadej Borovšak 2010-04-28 09:35:17 UTC 
Created attachment 159770 [details] [review]
Updated patch

Rebased patch on git master and updated it with suggestions.
Comment 3 Javier Jardón (IRC: jjardon) 2010-04-28 16:49:29 UTC 
Comment on attachment 159770 [details] [review]
Updated patch

commit ef4e7b247358c8c4fa67f8339f986831d06b66c9
Comment 4 Javier Jardón (IRC: jjardon) 2010-04-28 16:49:39 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.