After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610672 - overlay examples are now inconsistent and broken
overlay examples are now inconsistent and broken
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal blocker
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-22 11:10 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2010-02-22 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add *all* files to ignore list (598 bytes, patch)
2010-02-22 11:10 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review
fix find_video_sink and sync the examples (7.54 KB, patch)
2010-02-22 11:13 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-22 11:10:02 UTC
patches comming
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-22 11:10:40 UTC
Created attachment 154374 [details] [review]
add *all* files to ignore list

I had this as a local commit already and would have pushed this after the repo is open again. the version tim committed misses the files generated by moc.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-22 11:13:39 UTC
Created attachment 154375 [details] [review]
fix find_video_sink and sync the examples

I tried to make the examples similar in functionality. This patch catches up with tims additions to the gtk example (set the title and check for video sink).
It also fixes the newly added find_video_sink in the gtk example.
Comment 3 Tim-Philipp Müller 2010-02-22 12:19:49 UTC
Thanks for the fixes.

-/* slightly convoluted way to find a working video sink that's not a bin */
+/* slightly convoluted way to find a working video sink that's not a bin,
+ * one could use autovideosink from gst-plugins-good instead
+ */

is no really true though, since autovideosink doesn't implement the GstXOverlay interface, so the code won't work with it in its current form.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2010-02-22 13:21:45 UTC
Right. We could add more API to autovideosink. Right now one can filter sink candidates by caps. We could add a flags property and define a first flag as
GST_AUTO_VIDEO_SINK_CAN_XOVERLAY = 1.
Dunno if one would filter for e.g. videobalance etc.