After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610432 - [asfdemux] handle negative payload timestamps
[asfdemux] handle negative payload timestamps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal blocker
: 0.10.14
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-19 09:14 UTC by Edward Hervey
Modified: 2010-02-19 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
asfdemux: Make sure we don't end up with negative timestamps. (1.74 KB, patch)
2010-02-19 09:15 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2010-02-19 09:14:52 UTC 
Some files [1] might have payloads with timestamps smaller than the preroll value. Currently we blindly substract the preroll value from those timestamps, resulting in pushing out buffers with insanely high timestamps... screwing up sync downstream.

The following patch makes sure we never end up with wrong timestamps.

[1] Agreed, those files were most likely created by a broken muxer, or captured in some weird fashion and it should never happen on spec-compliant (sic) asf files. Better be safe than sorry though.
Comment 1 Edward Hervey 2010-02-19 09:15:18 UTC 
Created attachment 154188 [details] [review]
asfdemux: Make sure we don't end up with negative timestamps.

Some files have payload with timestamps smaller than the preroll duration.
Instead of blindly substracting the preroll value (and ending up with
insanely high timestamps on the outgoing buffers), we make sure we
never go below 0.

Fixes #610432
Comment 2 Edward Hervey 2010-02-19 17:11:32 UTC 
commit 417e3e034649cb3cb00ea52e52d8ea8a9ef3147b
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Fri Feb 19 10:13:34 2010 +0100

    asfdemux: Make sure we don't end up with negative timestamps.
    
    Some files have payload with timestamps smaller than the preroll duration.
    Instead of blindly substracting the preroll value (and ending up with
    insanely high timestamps on the outgoing buffers), we make sure we
    never go below 0.
    
    Fixes #610432