GNOME Bugzilla – Bug 610329
[theoradec] doesn't copy all chroma lines for 4:2:2
Last modified: 2010-02-21 16:55:21 UTC
Stupid one liner. Pushing now because when the RM tells me to, I'll be asleep. Note the mixed width/height: diff --git a/ext/theora/gsttheoradec.c b/ext/theora/gsttheoradec.c index 6eef472..ad23bd9 100644 --- a/ext/theora/gsttheoradec.c +++ b/ext/theora/gsttheoradec.c @@ -1004,7 +1004,7 @@ theora_handle_image (GstTheoraDec * dec, th_ycbcr_buffer buf, GstBuffer ** out) for (plane = 0; plane < 3; plane++) { width = gst_video_format_get_component_width (format, plane, dec->width); - height = gst_video_format_get_component_width (format, plane, dec->height); + height = gst_video_format_get_component_height (format, plane, dec->height); stride = gst_video_format_get_row_stride (format, plane, dec->width); dest =
Thanks!
Not fixed, you forgot to push it :)
commit 5685e0a4b79fd730c013e25f01fa754acac5c5c2 Author: David Schleef <ds@schleef.org> Date: Wed Feb 17 21:22:54 2010 -0800 theoradec: Fix chroma copying for 4:2:2 Fix mixup of height/width, causing only half the chroma lines to be copied when outputting buffers. Fixes: #610329.
This change breaks the two samples videos at bug #609792 and the rendering of the attach pitivi project (not-linked?!)
slomo: Perhaps you meant a different bug?
Must've been some race condition instead, sorry.