After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 610210 - [PATCH] Fix compilation of fdsink and fdsrc with MSVC
[PATCH] Fix compilation of fdsink and fdsrc with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal normal
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-02-17 00:35 UTC by Andoni Morales
Modified: 2010-02-17 09:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Fix-compilation-of-fdsink-and-fdsrc-with-MSVC.patch (2.15 KB, patch)
2010-02-17 00:35 UTC, Andoni Morales 		committed Details | Review

Description Andoni Morales 2010-02-17 00:35:09 UTC 
Created attachment 153988 [details] [review]
0001-Fix-compilation-of-fdsink-and-fdsrc-with-MSVC.patch

This patch fixes the compilation of fdsink and fdsrc with MSVC. 
I have also removed the include of <io.h> when _MSC_VER is defined as in this case G_OS_WIN32 will ve also defined.
I don't like the double check in gstelements.c, but I didn't find a better way of doing it :/
Comment 1 Sebastian Dröge (slomo) 2010-02-17 09:05:41 UTC 
commit 470f42d437a4eb6f6dc159665cb25167c32d99a4
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Feb 17 10:04:54 2010 +0100

    corelements: Combine redundant code

commit f839b6627752c3d7114d4b93bd4ba8e5c6c3bf05
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Wed Feb 17 01:27:22 2010 +0100

    Fix compilation of fdsink and fdsrc with MSVC