GNOME Bugzilla – Bug 609215
[rsvg] fix compilation with MSVC
Last modified: 2010-02-09 07:59:27 UTC
Created attachment 153187 [details] [review] Patchs gstrsvgdec.c Visual C++ doesn't like #if's inside a statement it seems. The attached patch fixed the problem.
Thanks for the patch. Could you next time please supply a patch in git format-patch format? git format-patch -1 will create a patch from the last commit. (That way I won't have to type a commit message and your author name, and don't have to fix up the indenting). commit beeb8fa8ecfc315fc6a04dd684d6616e012c6ea9 Author: David Hoyt <dhoyt@llnl.gov> Date: Sun Feb 7 11:09:45 2010 +0100 rsvgdec: fix compilation with MSVC MSVC doesn't like #if #else within statements. Fixes #609215.
I apologize - I don't use git - I download the tarballs instead. Is there another program that would put them in the desired format? I don't mind hand editing the patches either so they match what you expect.
Ah well, in that case don't worry about it. Hand-editing is likely too much hassle, but you could always do something like this: git config --global user.name "Your Name" git config --global user.email "you@foobar.com" git init . git add . git commit -m 'Import 0.10.25 tarball' on a freshly unpacked tarball. You can then modify your files and do git add dir/file1 file2 file3 git commit which will pop up a dialog where you can type a commit message, and then git format-patch -1 which will create a file called 0001-xyz.patch