After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608858 - Modernize autotools configuration
Modernize autotools configuration
Status: RESOLVED FIXED
Product: notification-daemon
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: William Jon McCann
Depends on:
Blocks:
 
 
Reported: 2010-02-03 04:02 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-04-02 22:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Modernize autotools configuration (8.32 KB, patch)
2010-02-03 04:05 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Modernize autotools configuration.v2 (8.81 KB, patch)
2010-02-04 01:34 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-02-03 04:02:35 UTC
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-02-03 04:03:40 UTC
See also http://live.gnome.org/GnomeGoals/ModernAutotools
Comment 2 Javier Jardón (IRC: jjardon) 2010-02-03 04:05:13 UTC
Created attachment 152902 [details] [review]
Modernize autotools configuration

New requirements:
    autoconf >= 2.63.2
    automake >= 1.10
    libtool >= 2.2.6
    intltool >= 0.40.0

All these packages are available in debian stable (anyway, notification-daemon depends on GTK+ 2.18, so a recent distribution is needed)
Comment 3 William Jon McCann 2010-02-03 04:15:46 UTC
Cool.  Thanks for the patch.  Looks pretty good.  I think my only question is does the gnome compiler warnings thing have at least the same warning checks that we have here?
Comment 4 Javier Jardón (IRC: jjardon) 2010-02-03 04:30:25 UTC
Hello William,

I'm afraid not :(

Check the macro source: http://git.gnome.org/browse/gnome-common/tree/macros2/gnome-compiler-flags.m4#n32

Maybe the best solution is make a patch for gnome-commonso so everyone can benefit from the new warnings.
Comment 5 William Jon McCann 2010-02-03 04:33:19 UTC
Thanks for checking.  That sounds like a good idea.  Let's hold off committing this until we fix that one.  Behdad is a good source of information for compiler warnings if I recall correctly.

Also see:
http://mces.blogspot.com/2008/12/year-end-cleaning-ie-on-warning-options.html

Thanks!
Comment 6 William Jon McCann 2010-02-03 04:44:01 UTC
Though it seems like the other parts of the patch are fine to commit...
Comment 7 Javier Jardón (IRC: jjardon) 2010-02-04 01:34:05 UTC
Created attachment 152982 [details] [review]
Modernize autotools configuration.v2

Hello again,

I've modified the patch so still uses gnome-common macros, but check for the flags that are uncovered in gnome-common

Also, I've used a separate variable (WARNINGCFLAGS), because CFLAGS is a "user" variable. See this for more info:
http://www.gnu.org/software/hello/manual/automake/User-Variables.html#User-Variables
Comment 8 William Jon McCann 2010-04-02 20:56:13 UTC
Hmm,
    autoconf >= 2.63.2

Fedora 12 only has 2.63.  Is .2 really needed?
Comment 9 William Jon McCann 2010-04-02 22:49:45 UTC
Pushed with the change to only require 2.63.