After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608511 - Theme, button background, left_middle drawn for left_right
Theme, button background, left_middle drawn for left_right
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2010-01-30 10:58 UTC by awupcijwwewf
Modified: 2014-06-09 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Example theme (10.87 KB, text/xml)
2010-01-30 10:58 UTC, awupcijwwewf 		  Details
Screenshot, magnification, red is left_middle_background drawn behind left_right_background (11.35 KB, image/png)
2010-01-30 11:01 UTC, awupcijwwewf 		  Details
Screenshot, magnification, right_middle_background drawn behind right_right_background (9.55 KB, image/png)
2010-01-30 11:12 UTC, awupcijwwewf 		  Details
Metacity 2.28.1 button background patch (4.41 KB, patch)
2010-03-16 22:58 UTC, noop 		committed Details | Review

Description awupcijwwewf 2010-01-30 10:58:30 UTC 
Created attachment 152620 [details]
Example theme

draw_ops specified for button function=left_middle_background are also drawn for button function=left_right_background. draw_ops specified for button function=left_right_background are then drawn over this.

This makes some theme ideas extremely hard to realize (transparent corners of buttons for left_left and left_right, but not for left_middle).
Comment 1 awupcijwwewf 2010-01-30 11:01:58 UTC 
Created attachment 152621 [details]
Screenshot, magnification, red is left_middle_background drawn behind left_right_background
Comment 2 awupcijwwewf 2010-01-30 11:12:07 UTC 
Created attachment 152623 [details]
Screenshot, magnification, right_middle_background drawn behind right_right_background

This also happens for button function=right_middle_background being drawn behind button function=right_right_background.
Comment 3 noop 2010-03-15 09:04:45 UTC 
Commited a patch on Launchpad for this problem.

https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/535088

You can get then patch here :

http://launchpadlibrarian.net/40918098/Metacity-2.28.1-patch
Comment 4 noop 2010-03-16 22:58:31 UTC 
Created attachment 156312 [details] [review]
Metacity 2.28.1 button background patch

This patch correct multiple problems :

 - Transparent backgrounds which overlap
 - Background applied when only one button
 - Left button clickable by clicking on his left when window is maximised
Comment 5 noop 2010-03-20 13:35:57 UTC 
Updated patch.

Added some comments where I made modifications.
Reported modifications I made for the left side to the right side.
Rolled back some modifications I made, which didn't seems to do anything so I prefer to leave code unmodified in this case.

You can again find the bug report here :

https://bugs.launchpad.net/ubuntu/+source/metacity/+bug/535088

And the new patch here :

http://launchpadlibrarian.net/41414008/Metacity-2.28.1-20100320.patch

If you need more comments on the modifications I made, feel free to ask for.
Comment 6 Adnan Hodzic 2011-01-25 09:59:02 UTC 
I'm working on implementing light-themes into Debian and I have a problem which this patch fixes: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=610936

However apparently this patch hasn't been pushed upstream yet, could you please do so? 


Thanks,

Adnan