After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608422 - [Win32] ssconvert cannot output to fd://1
[Win32] ssconvert cannot output to fd://1
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
1.9.x
Other Windows
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-01-29 09:42 UTC by Franz Quehenberger
Modified: 2010-03-09 21:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (534 bytes, patch)
2010-03-09 15:08 UTC, Jean Bréfort
none Details | Review
Updated patch (637 bytes, patch)
2010-03-09 16:52 UTC, Jean Bréfort
committed Details | Review

Description Franz Quehenberger 2010-01-29 09:42:04 UTC
This is the example code that produces the error:

C:\Programme>ssconvert --export-type=Gnumeric_stf:stf_csv  test.xls fd://1
E ╗file:///C:/Programme/fd:/1½ konnte nicht zum Schreiben ge÷ffnet werden: C:\Pr
ogramme\fd:\.gsf-save-7JDO7U: Invalid argument

The english translation probaly is:
C:\programs>ssconvert --export-type=Gnumeric_stf:stf_csv  test.xls fd://1
E ╗file:///C:/Programme/fd:/1½ could not be opended for writing: C:\programs\fd:\.gsf-save-7JDO7U: Invalid argument

As there is bug report/feature request for fd://1 as stdout that had been resolved, I assume that it has not been tested on the windows (XP) platform. I found out that the go_file_create function should handle fd://1, however I am not a programmer.
Comment 1 Morten Welinder 2010-01-30 23:24:42 UTC
Strange.  There is nothing win32 specific there.  It might be a bug
over in glib land -- we'll need to investigate.
Comment 2 Franz Quehenberger 2010-02-01 13:03:22 UTC
In the meantime Karoly Antal, who wrote an the R (www.r-project.org) package "gnumeric" which calls "ssconvert" trough a pipe which relies on fd://1, has tested ssconert with WINE: 

On version 1.9.16 (latest win32 build) ssconvert fd://1 did not work with WINE. However gnumeric-1.9.0-win32-1.exe downloaded from http://www.gnome.org/~jody/gnumeric/win32/ DID work with WINE.

I tested on my Windows XP workstation:
gnumeric-1.9.0-win32-1 worked with ssconvert infile outfile, but ssconvert -h produced no output. "ssconvert --export-type=Gnumeric_stf:stf_csv  test.xls fd://1" produced neither an output nor an error message. So something is wrong with this version as well, at least with Windows XP. 

Finally I would like to remark that http://www.gnome.org/~jody/gnumeric/win32/ does not offer any 1.8.x version compiled for windows for download.
Comment 3 Andreas J. Guelzow 2010-02-10 06:44:10 UTC
"Finally I would like to remark that http://www.gnome.org/~jody/gnumeric/win32/
does not offer any 1.8.x version compiled for windows for download."

Why would you want an ancient version of Gnumeric compiled on WIndows when most of the development to make GNumeric work properly under Windows happened in 1.9.x?
Comment 4 Franz Quehenberger 2010-02-12 11:11:42 UTC
(In reply to comment #3)
> "Finally I would like to remark that http://www.gnome.org/~jody/gnumeric/win32/
> does not offer any 1.8.x version compiled for windows for download."
> 
> Why would you want an ancient version of Gnumeric compiled on WIndows when most
> of the development to make GNumeric work properly under Windows happened in
> 1.9.x?
Just for testing. In addition as a user I sometimes wish to have an old version that workes, however with reduced fuctionality.
Comment 5 Jean Bréfort 2010-03-08 21:09:13 UTC
Nothing related to go_file_create, actually, something wrong in gio. Needs more investigation.
Comment 6 Jean Bréfort 2010-03-08 21:35:38 UTC
Default vfs under win32 id GWinHttpVfs which support only http: and https: and its fallback is GLocalVfs which seems to consider that everything is file:. In the end, the GFile is created by a call to _g_local_file_new("fd://1"); which is full wrong. This also occurs with other URI such as ftp:.
Comment 7 Jean Bréfort 2010-03-09 15:08:16 UTC
Created attachment 155656 [details] [review]
Proposed patch

Fixes the fd:// issue.
Comment 8 Morten Welinder 2010-03-09 16:11:43 UTC
Looks good.

Could you drop the "else" and move the braces into the non-win32 case
before you commit?  That would play nicer with Emacs.
Comment 9 Jean Bréfort 2010-03-09 16:52:17 UTC
Created attachment 155663 [details] [review]
Updated patch
Comment 10 Morten Welinder 2010-03-09 19:32:58 UTC
Go for it.
Comment 11 Jean Bréfort 2010-03-09 21:04:06 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.