After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 608112 - Modernize autotools configuration
Modernize autotools configuration
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2010-01-26 00:32 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-01-26 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Modernize autotools configuration (4.07 KB, patch)
2010-01-26 00:36 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-01-26 00:32:56 UTC 
Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-01-26 00:36:16 UTC 
Created attachment 152275 [details] [review]
Modernize autotools configuration

I've replaced all autoconf deprecated macros.

I've updated some required dependencies too, all these packages are present in
Debian stable or current Ubuntu (anyway, gedit depends on GTK+ 2.16, which is
only present in recent distributions)

New required dependencies
    autoconf >= 2.63.2 (so you can use the url parameter of AC_INIT())
    automake >= 1.10 (1.8 is very old)
    libtool >= 2.2.6 (so you can use thenew  LT_INIT() syntax)
Comment 2 Ignacio Casal Quinteiro (nacho) 2010-01-26 09:29:32 UTC 
Review of attachment 152275 [details] [review]:

Apart from the minor comment bellow the patch looks good to me.

::: configure.ac
@@ -18,1 @@
 AC_DEFINE(GEDIT_MICRO_VERSION, gedit_micro_version, [Gedit micro version])

You sure you can remove here GEDIT_MINOR_VERSION ?
Comment 3 Ignacio Casal Quinteiro (nacho) 2010-01-26 15:41:31 UTC 
Comment on attachment 152275 [details] [review]
Modernize autotools configuration

Checking again seems the review tool marked as removed that line but it is not removed, so feel free to push it.
Comment 4 Javier Jardón (IRC: jjardon) 2010-01-26 17:06:22 UTC 
Comment on attachment 152275 [details] [review]
Modernize autotools configuration

commit e77d04df2ce879ef2915069436d3f68d09959f63
Comment 5 Javier Jardón (IRC: jjardon) 2010-01-26 17:06:55 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release.

Thank you Nacho for the review.