After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 606933 - Epiphany crash when deleting saved passwords
Epiphany crash when deleting saved passwords
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
2.30.x
Other Linux
: High critical
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 615167 626787 628749 632432 634212 634213 634214 639278 642552 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-01-14 08:50 UTC by FelipeDarder
Modified: 2011-02-17 11:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30



Description FelipeDarder 2010-01-14 08:50:38 UTC
@ Debian Squeeze/Sid > Epiphany 2.29.5 (without any plugins)

I read somewhere that saving passwords was not a milestone for this version of Epiphany. But when I attempt to clear the temporary files, the "erase saved passwords" chechbox is there. If i select that checkbox and press delete, Epiphany crashes.

Here's the full trace...

http://pastebin.org/75986

Thanks :)
Comment 1 Akhil Laddha 2010-01-14 11:28:31 UTC
Please paste traces in bug it self next time, thanks.

Thanks for taking the time to report this bug.
Unfortunately, that stack trace is missing some elements that will help a lot to solve the problem, so it will be hard for the developers to fix that crash. Can you get us a stack trace with debugging symbols? Please see http://live.gnome.org/GettingTraces for more information on how to do so. Thanks in advance!
Comment 2 FelipeDarder 2010-01-14 20:23:17 UTC
Thanks for replying so fast!

Hope this is what you're looking for...

Starting program: /usr/bin/epiphany-browser 
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffe5362910 (LWP 25877)]
[New Thread 0x7fffe4a61910 (LWP 25878)]
[New Thread 0x7fffe4260910 (LWP 25879)]
[Thread 0x7fffe4260910 (LWP 25879) exited]

(epiphany:25870): GLib-GObject-WARNING **: IA__g_object_set_valist: object class `SoupSessionAsync' has no property named `accept-language'
[New Thread 0x7fffe4260910 (LWP 25899)]
[New Thread 0x7fffe127b910 (LWP 25900)]
[Thread 0x7fffe127b910 (LWP 25900) exited]

(epiphany:25870): GLib-GObject-WARNING **: invalid cast from `PrefsDialog' to `PdmDialog'

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff416ed53 in IA__gtk_tree_model_get_iter_first (
    tree_model=0x1b00000055, iter=0x7fffffffbf10)
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c:1083
1083	/build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c: No existe el fichero o el directorio.
	in /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c
(gdb) thread apply all bt

Thread 1 (Thread 0x7ffff7fbf800 (LWP 25870))

  • #0 IA__gtk_tree_model_get_iter_first
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c line 1083
  • #1 clear_all_dialog_response_cb
    at /epiphany-browser-2.29.5/src/pdm-dialog.c line 289
  • #2 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.22.3/gobject/gclosure.c line 767
  • #3 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3247
  • #4 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 2980
  • #5 IA__g_signal_emit
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3037
  • #6 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.22.3/gobject/gclosure.c line 767
  • #7 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3247
  • #8 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 2980
  • #9 IA__g_signal_emit
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3037
  • #10 gtk_real_button_released
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkbutton.c line 1707
  • #11 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.22.3/gobject/gclosure.c line 767
  • #12 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3177
  • #13 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 2980
  • #14 IA__g_signal_emit
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3037
  • #15 gtk_button_button_release
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkbutton.c line 1599
  • #16 _gtk_marshal_BOOLEAN__BOXED
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmarshalers.c line 84
  • #17 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.22.3/gobject/gclosure.c line 767
  • #18 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3285
  • #19 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 2990
  • #20 IA__g_signal_emit
    at /build/buildd/glib2.0-2.22.3/gobject/gsignal.c line 3037
  • #21 gtk_widget_event_internal
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkwidget.c line 4767
  • #22 IA__gtk_propagate_event
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmain.c line 2417
  • #23 IA__gtk_main_do_event
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmain.c line 1622
  • #24 gdk_event_dispatch
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gdk/x11/gdkevents-x11.c line 2372
  • #25 g_main_dispatch
    at /build/buildd/glib2.0-2.22.3/glib/gmain.c line 1960
  • #26 IA__g_main_context_dispatch
    at /build/buildd/glib2.0-2.22.3/glib/gmain.c line 2513
  • #27 g_main_context_iterate
    at /build/buildd/glib2.0-2.22.3/glib/gmain.c line 2591
  • #28 IA__g_main_loop_run
    at /build/buildd/glib2.0-2.22.3/glib/gmain.c line 2799
  • #29 IA__gtk_main
  • #30 main
    at /epiphany-browser-2.29.5/src/ephy-main.c line 741

Comment 3 Reinout van Schouwen 2010-01-14 22:52:31 UTC
Trace looks unique, but I suspect it's something in gtk+ or glib.
Comment 4 Gustavo Noronha (kov) 2010-01-29 19:28:52 UTC
Nah, the crash is inside Epiphany.

			PdmDialog *pdialog = EPHY_PDM_DIALOG (checkbuttons->dialog);
			PdmActionInfo *pinfo = pdialog->priv->passwords;

			gboolean valid = gtk_tree_model_get_iter_first (pinfo->model, &iter);

EPHY_PDM_DIALOG doesn't agree checkbuttons->dialog is a PdmDialog, there's a NULL derreference in pdialog->priv->passwords, and finally the crash in gtk_tree_model_get_iter_first. I can't reproduce the crash, though. Can you try upgrading to Epiphany, and soup from unstable?
Comment 5 FelipeDarder 2010-02-02 20:29:50 UTC
Upgraded:

epiphany-browser > 2.29.6
libsoup2.4-1 > 2.29.6-1
libsoup-gnome2.4-1 > 2.29.6-1

(epiphany:5656): GLib-GObject-WARNING **: invalid cast from `PrefsDialog' to `PdmDialog'

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff417ad53 in IA__gtk_tree_model_get_iter_first (tree_model=0x1b00000055, iter=0x7fffffffbf10)
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c:1083
1083	/build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c: No existe el fichero o el directorio.
	in /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c
(gdb) thread apply all bt

Thread 1 (Thread 0x7ffff7fbf800 (LWP 5656))

  • #0 IA__gtk_tree_model_get_iter_first
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtktreemodel.c line 1083
  • #1 clear_all_dialog_response_cb
    at /tmp/buildd/epiphany-browser-2.29.6/src/pdm-dialog.c line 289
  • #2 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.22.4/gobject/gclosure.c line 767
  • #3 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3247
  • #4 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 2980
  • #5 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3037
  • #6 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.22.4/gobject/gclosure.c line 767
  • #7 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3247
  • #8 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 2980
  • #9 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3037
  • #10 gtk_real_button_released
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkbutton.c line 1707
  • #11 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.22.4/gobject/gclosure.c line 767
  • #12 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3177
  • #13 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 2980
  • #14 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3037
  • #15 gtk_button_button_release
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkbutton.c line 1599
  • #16 _gtk_marshal_BOOLEAN__BOXED
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmarshalers.c line 84
  • #17 IA__g_closure_invoke
    at /tmp/buildd/glib2.0-2.22.4/gobject/gclosure.c line 767
  • #18 signal_emit_unlocked_R
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3285
  • #19 IA__g_signal_emit_valist
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 2990
  • #20 IA__g_signal_emit
    at /tmp/buildd/glib2.0-2.22.4/gobject/gsignal.c line 3037
  • #21 gtk_widget_event_internal
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkwidget.c line 4767
  • #22 IA__gtk_propagate_event
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmain.c line 2417
  • #23 IA__gtk_main_do_event
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmain.c line 1622
  • #24 gdk_event_dispatch
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gdk/x11/gdkevents-x11.c line 2372
  • #25 g_main_dispatch
    at /tmp/buildd/glib2.0-2.22.4/glib/gmain.c line 1960
  • #26 IA__g_main_context_dispatch
    at /tmp/buildd/glib2.0-2.22.4/glib/gmain.c line 2513
  • #27 g_main_context_iterate
    at /tmp/buildd/glib2.0-2.22.4/glib/gmain.c line 2591
  • #28 IA__g_main_loop_run
    at /tmp/buildd/glib2.0-2.22.4/glib/gmain.c line 2799
  • #29 IA__gtk_main
    at /build/buildd-gtk+2.0_2.18.5-1-amd64-Nathc9/gtk+2.0-2.18.5/gtk/gtkmain.c line 1218
  • #30 main
    at /tmp/buildd/epiphany-browser-2.29.6/src/ephy-main.c line 741

Comment 6 not real name 2010-02-03 04:29:53 UTC
In Epiphany when clearing "saved passwords" (Edit menu -> Prefences -> Privacy tab -> Clear button -> select "Saved Passwords" (and select or deselect the other checkboxes as required) -> Clear button.

Does not matter if "Remember passwords" is selected or not, nor, as far as I can tell, any other settings. 


From the about box:"Web Browser 2.28.0", OS is Ubuntu 9.10. This was happening without any extensions.

---

As far as I can tell, Epiphany doesn't even remember passwords...

---

Looks like I don't have to create a new bug report. This is just to confirm that it happens for me as well.
Comment 7 Reinout van Schouwen 2010-04-08 15:04:44 UTC
*** Bug 615167 has been marked as a duplicate of this bug. ***
Comment 8 Reinout van Schouwen 2010-04-08 15:04:59 UTC
Does the problem still happen with 2.30?
Comment 9 FelipeDarder 2010-04-09 03:00:52 UTC
Upgraded:
epiphany-browser > 2.30

The problem is still there, behaves exactly like 2.28
Comment 10 FelipeDarder 2010-04-12 03:14:19 UTC
@ debian squeeze/sid [amd64] (epiphany 2.30.2-1) keeps crashing.
@ ubuntu lucid beta2 [amd64] fresh install (epiphany 2.29.92) happens too.
Comment 11 Irv Fullerton 2010-07-20 16:24:00 UTC
As I don't see any recent activity on this bug, I want to add/clarify that that process of clearing all personal data does work using the following link:  Edit>Personal Data>Clear All. When selecting all 4 choices...the browser does not crash. However, when using Edit>Preferences>Privacy>Temporary Files>Clear - the brower crashes when Saved Passwords is checked, and clear is then selected.

As information, I'm using Epiphany 2.30.2 with the Ubuntu 10.04 Netbook Edition.
Comment 12 Patrick Welche 2010-07-23 21:09:38 UTC
I see exactly the same thing as per comment 11. (10.04.1 laptop)
Comment 13 Reinout van Schouwen 2010-08-13 10:10:01 UTC
*** Bug 626787 has been marked as a duplicate of this bug. ***
Comment 14 Xan Lopez 2010-09-01 08:58:04 UTC
(In reply to comment #4)
> Nah, the crash is inside Epiphany.
> 
>             PdmDialog *pdialog = EPHY_PDM_DIALOG (checkbuttons->dialog);
>             PdmActionInfo *pinfo = pdialog->priv->passwords;
> 
>             gboolean valid = gtk_tree_model_get_iter_first (pinfo->model,
> &iter);
> 
> EPHY_PDM_DIALOG doesn't agree checkbuttons->dialog is a PdmDialog, there's a
> NULL derreference in pdialog->priv->passwords, and finally the crash in
> gtk_tree_model_get_iter_first. I can't reproduce the crash, though. Can you try
> upgrading to Epiphany, and soup from unstable?

Ephy does not agree checkbuttons->dialog is a PdmDialog because it isn't. This is called intially from prefs-dialog.c, with dialog being one of those. That's why we get:

(epiphany:25870): GLib-GObject-WARNING **: invalid cast from `PrefsDialog' to
`PdmDialog'

We managed to break the code by making this pdm function only be able to work with PdmDialogs, which wasn't the case before.
Comment 15 Xan Lopez 2010-09-01 13:27:00 UTC
Basically, I think we need to move the PDM data to some place where it can be accessed by both PDM and Prefs dialog. I don't think having it be dependent on the PDM dialog treeview is a good design in any way.
Comment 16 Diego Escalante Urrelo (not reading bugmail) 2010-09-02 20:54:27 UTC
I think we can -for the sake of avoiding the crash- move this to ephy-embed-single.c (where other keyring (form data) stuff is).

We could have ephy_embed_single_get_keyring_items (embed, gtktreemodel) that fills the given GtkTreeModel async with all the stuff it can find in the keyring (or that it has cached somehow).

That, just for now. I would like to hack an EphyPDM or something like that in the near future, it could also proxy stuff like enabling/disabling history and maybe other stuff.
Comment 17 win2lin 2010-09-04 02:05:13 UTC
*** Bug 628749 has been marked as a duplicate of this bug. ***
Comment 18 Xan Lopez 2010-09-05 13:33:34 UTC
OK, this should be fixed in master now. Commit 479f0a9a7ec095a8457e7d5b70695207e81f40c6.
Comment 19 Reinout van Schouwen 2010-10-18 22:18:52 UTC
*** Bug 632432 has been marked as a duplicate of this bug. ***
Comment 20 Akhil Laddha 2010-11-07 12:49:11 UTC
*** Bug 634212 has been marked as a duplicate of this bug. ***
Comment 21 Akhil Laddha 2010-11-07 12:49:18 UTC
*** Bug 634213 has been marked as a duplicate of this bug. ***
Comment 22 Akhil Laddha 2010-11-07 12:49:28 UTC
*** Bug 634214 has been marked as a duplicate of this bug. ***
Comment 23 Akhil Laddha 2011-01-12 04:06:43 UTC
*** Bug 639278 has been marked as a duplicate of this bug. ***
Comment 24 Akhil Laddha 2011-02-17 11:18:02 UTC
*** Bug 642552 has been marked as a duplicate of this bug. ***