After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 604814 - videomixer make error
videomixer make error
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-12-17 09:41 UTC by sreerenj
Modified: 2009-12-17 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videomixer: Fix assembly compilation on x86 (2.46 KB, patch)
2009-12-17 15:01 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description sreerenj 2009-12-17 09:41:36 UTC
When i tried to install the git version of gst-plugins-good in my feodora9 ,i got the follwing errors in make and in make ERROR_CFLAGS=''

Making all in videomixer
  CC    blend_ayuv.o
blend_ayuv.c: In function 'gst_videomixer_blend_ayuv_ayuv_mmx':
blend_ayuv.c:285: error: can't find a register in class 'GENERAL_REGS' while reloading 'asm'
blend_ayuv.c:285: error: 'asm' operand has impossible constraints
make[3]: *** [libgstvideomixer_la-blend_ayuv.lo] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Comment 1 Tim-Philipp Müller 2009-12-17 09:48:18 UTC
Next time, could you please re-open the bug you previously filed instead of just filing another identical one without any additional explanation?

What is the output of:

  git describe

?
Comment 2 sreerenj 2009-12-17 09:52:20 UTC
RELEASE-0.10.16-228-g2543d9c
Comment 3 sreerenj 2009-12-17 10:02:36 UTC
I am really Sorry ,
This is the version
RELEASE-0.10.17-107-g4063bb8

problem persists
Comment 4 Tim-Philipp Müller 2009-12-17 10:07:29 UTC
Ok, let's try this: what's the output of:

  git log -2 gst/videomixer/

?
Comment 5 sreerenj 2009-12-17 10:24:33 UTC
git log -2 gst/videomixer/
commit 0a0f7ecc1646751ea820bd68846f24edc755d352
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Dec 16 10:50:32 2009 +0100

    videomixer: Use movzbl instead of movzxb for moving one byte to a l register
    
    For some reason latest gcc/binutils accept movzxb here while
    movzbl would be correct and is the only thing accepted by older
    gcc/binutils.
    
    Fixes bug #604679.

commit 9e45038d8d15db29deed5265fab7b37ae8971de1
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Dec 16 06:59:01 2009 +0100

    videomixer: src/dest are input and output of the AYUV blending MMX assembler
Comment 6 sreerenj 2009-12-17 10:26:19 UTC
when i tried to install a previous version(RELEASE-0.10.16-228-g2543d9c), there is no problem. 

Problem arrives when i tried to install (RELEASE-0.10.17-107-g4063bb8) .
Comment 7 Tim-Philipp Müller 2009-12-17 10:32:17 UTC
Ok, thanks, just making sure you are actually up to date.
Comment 8 Sebastian Dröge (slomo) 2009-12-17 15:01:53 UTC
Created attachment 149918 [details] [review]
videomixer: Fix assembly compilation on x86

Fixes bug #604814.
Comment 9 Sebastian Dröge (slomo) 2009-12-17 15:03:41 UTC
(In reply to comment #8)
> Created an attachment (id=149918) [details] [review]
> videomixer: Fix assembly compilation on x86
> 
> Fixes bug #604814.

This might fix it... please test :) Problem was that x86 simply has too few GP registers... solution now is to steal ebx for this (which is used for PIC code, thus needs to be restored later).
Comment 10 Edward Hervey 2009-12-17 17:09:56 UTC
Still seems to fail with this patch applied on x86 (macosx):

/var/tmp//ccQQFTR4.s:757:suffix or operands invalid for `movq'
make[3]: *** [libgstvideomixer_la-blend_ayuv.lo] Error 1
Comment 11 Sebastian Dröge (slomo) 2009-12-17 17:15:14 UTC
commit 3ac6f5e48bef1066cc56ea800242141acd842b2c
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Dec 17 16:01:25 2009 +0100

    videomixer: Fix assembly compilation on x86
    
    Fixes bug #604814.