After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603949 - Use accessor functions instead direct access (use GSEAL GnomeGoal)
Use accessor functions instead direct access (use GSEAL GnomeGoal)
Status: RESOLVED FIXED
Product: gtkglext
Classification: Other
Component: general
1.1.x
Other All
: Normal normal
: 2.0.0
Assigned To: Braden
Mukund Sivaraman
: 618601 (view as bug list)
Depends on:
Blocks: 585391
 
 
Reported: 2009-12-07 07:10 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-07-19 07:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use accessor functions instead direct access (4.68 KB, patch)
2009-12-07 07:15 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use accessor functions instead direct accessv2 (5.67 KB, patch)
2010-02-09 20:02 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use accessor functions instead direct access.v3 (3.84 KB, patch)
2010-04-25 20:39 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use accessor functions instead direct access.v4 (3.84 KB, patch)
2010-04-25 20:43 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Use accessor functions instead direct access.v5 (55.86 KB, patch)
2010-04-25 22:22 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-12-07 07:10:11 UTC 
To be ready for GTK+ 3, gtkglext should be able to build with -DGSEAL_ENABLE

See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-12-07 07:15:14 UTC 
Created attachment 149230 [details] [review]
Use accessor functions instead direct access

GTK+ 2.18 is now the required version
I've used all the GTK+ 2.18 api available, still missing:
GTK_WIDGET_REALIZED()
Comment 2 Mukund Sivaraman 2010-01-11 20:57:56 UTC 
Setting milestone to 2.0.0.
Comment 3 Mukund Sivaraman 2010-01-11 21:09:01 UTC 
jjardon: Do you know if GTK_WIDGET_REALIZED() is now available in any release? If not will it be? What's holding it up?

I want to clear up the 2.0.0 milestone bugs quickly :)
Comment 4 Mukund Sivaraman 2010-01-11 21:09:58 UTC 
(In reply to comment #3)
> jjardon: Do you know if GTK_WIDGET_REALIZED() is now available in any release?
> If not will it be? What's holding it up?

And by that, obviously I meant the accessor function that replaces that macro :)
Comment 5 Javier Jardón (IRC: jjardon) 2010-01-12 03:05:06 UTC 
(In reply to comment #3)
> jjardon: Do you know if GTK_WIDGET_REALIZED() is now available in any release?
> If not will it be? What's holding it up?

Still not. Take a look to the blocker bug #69872

The accessor should be ready for GTK+ 2.20, so as soon as the bug is fixed, I'll make a new patch ;)
Comment 6 Javier Jardón (IRC: jjardon) 2010-02-09 20:02:50 UTC 
Created attachment 153363 [details] [review]
Use accessor functions instead direct accessv2

GTK+ api for GTK_WIDGET_REALIZED() landed today, so here your patch ;)
Comment 7 Javier Jardón (IRC: jjardon) 2010-04-06 18:59:23 UTC 
Desn't depends on bug #69872 anymore
Comment 8 Javier Jardón (IRC: jjardon) 2010-04-25 20:39:32 UTC 
Created attachment 159546 [details] [review]
Use accessor functions instead direct access.v3

Updated patch against current master
Comment 9 Javier Jardón (IRC: jjardon) 2010-04-25 20:43:20 UTC 
Created attachment 159547 [details] [review]
Use accessor functions instead direct access.v4

Forgot to update GTK+ required version in configure.ac
Comment 10 Javier Jardón (IRC: jjardon) 2010-04-25 22:22:34 UTC 
Created attachment 159557 [details] [review]
Use accessor functions instead direct access.v5

Do not get rid of the stuff that tests if GTK_LIBS was set
Comment 11 Javier Jardón (IRC: jjardon) 2010-04-26 00:33:54 UTC 
Comment on attachment 159557 [details] [review]
Use accessor functions instead direct access.v5

commit 99e8649f598ca00647cfa7159afa0d5f6e84a7c4
Comment 12 Javier Jardón (IRC: jjardon) 2010-04-26 00:34:07 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 13 Mukund Sivaraman 2010-07-19 07:53:57 UTC 
*** Bug 618601 has been marked as a duplicate of this bug. ***