After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 603203 - More frame rate support
More frame rate support
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: User interface
0.13.x
Other Linux
: Normal normal
: 0.13.4
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-28 07:28 UTC by Eugenia Loli-Queru
Modified: 2010-03-05 01:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cleanup patch ♥ (1.39 KB, patch)
2009-12-04 19:19 UTC, Jean-François Fortin Tam
none Details | Review

Description Eugenia Loli-Queru 2009-11-28 07:28:18 UTC
Please add support for all of the following frame rates.

12 (some old cellphones)
15 (many digicams/cellphones shoot as such)
23.976 (not just 23.97)
24 (film speed)
25 (most PAL camcorders in PF25 mode)
29.97 (most NTSC camcorders in PF30 mode)
30 (most digicams)
50 (e.g. the popular Canon 7D shoots as such)
59.94 (e.g. Sanyo HD2000)
60 (e.g. Kodak Zi8)
120 (e.g. RED One, LG KU990)

That will do it for 99% of the situations. Currently, you cover about 80%.
Comment 1 Jean-François Fortin Tam 2009-12-04 19:19:05 UTC
Created attachment 149111 [details] [review]
cleanup patch ♥

Here is a patch that solves this :)

I also cleaned up the order and spacing between items (for PEP-8 compliance). Did not touch the code other than video_rates though.

P.s.: Notice that while it displayed "23,97 fps", internally, pitivi was using 24000:1001. Also, if using custom resolution and framerate settings, you may be bit by bug 598342.
Comment 2 Jean-François Fortin Tam 2010-02-05 23:15:54 UTC
Please review the patch, and if it's not complete madness, include it (until we have user-editable fields anyway), so that it doesn't just bitrot here (Brandon could take a look perhaps?).
Comment 3 Alessandro Decina 2010-03-05 01:00:43 UTC
Thanks jeff :)

commit 2593f5e64f31c29afc58467b2cd36b7bbe08f45a
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Fri Mar 5 01:59:12 2010 +0100

    Add more video frame rates. Fixes #603203.