GNOME Bugzilla – Bug 603045
[regression] viewer no longer displays after dropping files
Last modified: 2009-12-10 21:47:07 UTC
The following commit breaks the behaviour by which when you put objects in the timeline, the viewer would display the timeline. Reproducable by: * loading a project * or adding a file to a blank timeline by using [insert] * or by dragging a file on a blank timeline commit af7c3b26a9dea1ab3f201b791a482aa49bab3f9e Author: Brandon Lewis <brandon_lewis@alum.berkeley.edu> Date: Mon Nov 23 22:26:01 2009 -0800 ruler.py: remove unnecessary seek request, ensures previous commit always works
This seek request occurs every time the timeline duration changes (which is often), and will override the seek-on-click behavior (returning the playhead to its original position). Wouldn't it be better to issue this request directly after adding sources to the timeline. And we should figure out why setShadedDuration() is called so frequently.
if there's code that already returns the playhead to its original position, then great. And yes, we should definitely: * only do a initial seek when adding sources * figure out why setShadedDuration is called so frequently
think i know what's behind this. I think it is also related to 60342, and 603102. Will investigate further tomorrow.
please review my branch fix_seeking_6030405_603424
correction: fix_seeking_603405_603424
commit 837f0d73b7d510b695ee1c9a1cb961c779ad6534 Author: Brandon Lewis <brandon_lewis@alum.berkeley.edu> Date: Wed Dec 9 15:10:10 2009 -0800 mainwindow.py,test_integration.py: issue preliminary seek on timeline closes bugs 603045, 603424, 603102