After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 602940 - jitterbuffer is racy determining basetime
jitterbuffer is racy determining basetime
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-25 14:03 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2009-11-28 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Stefan Sauer (gstreamer, gtkdoc dev) 2009-11-25 14:03:11 UTC
I have added some tests to gst-plugins-good for rtpjitterbuffer. They show there that is some racyness in how it figures its basetime. If my tests are broken, then it tells at least that jitterbuffer needs better docs.
Comment 1 Wim Taymans 2009-11-28 11:04:10 UTC
The test is very racy. The jitterbuffer does not have a clock and can't sync outgoing packets. This means that it does not wait for reordered packets to arrive but pushes as fast as it can. This makes it race against the chain function, causing random dropped packets.

The resync of the base_time is normal when packets are out of order.
Comment 2 Wim Taymans 2009-11-28 11:13:04 UTC
correction: it has a clock but the element base_time is not correctly set on the jitterbuffer.
Comment 3 Wim Taymans 2009-11-28 11:27:04 UTC
commit 5c8527bb20787ba68759b44d196896c5fb370ab4
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Sat Nov 28 12:25:06 2009 +0100

    check: fix jitterbuffer check
    
    Make sure we set a base_time on the element.
    Fix the timeout to at least twice the jitterbuffer latency.
    Enable previously failing tests.
    Remove impossible checks.