After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 601627 - theoradec breaks timestamps
theoradec breaks timestamps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-11-12 00:39 UTC by Olivier Crête
Modified: 2009-11-12 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theoradec: Keep timestamp from incoming buffer if it is valid (1.33 KB, patch)
2009-11-12 00:39 UTC, Olivier Crête 		committed Details | Review

Description Olivier Crête 2009-11-12 00:39:03 UTC 
theoradec currently replaces the timestamps on buffers with "perfect" timestamps from the granule. This breaks with any kind of live source that does not provide perfect timestamps like my v4l2 webcam (or a v4l2 webcam that generates RTP buffers). Or RTP buffers that have had their clock skew corrected.

Anyway, the patch just ignores the Granule timestamp if there already a valid Gstreamer timestamp on the buffer (so it still works with oggdemux, since it does not set one).
Comment 1 Olivier Crête 2009-11-12 00:39:06 UTC 
Created attachment 147520 [details] [review]
theoradec: Keep timestamp from incoming buffer if it is valid
Comment 2 Sebastian Dröge (slomo) 2009-11-12 12:18:28 UTC 
Thanks, pushed :)