After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600775 - Upgrade the UI from libglade to GtkBuilder
Upgrade the UI from libglade to GtkBuilder
Status: RESOLVED FIXED
Product: postr
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Postr Maintainers
Postr Maintainers
Depends on:
Blocks: 572883
 
 
Reported: 2009-11-05 03:49 UTC by Germán Poo-Caamaño
Modified: 2012-10-03 23:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
convert the postr.glade to glade3 format (25.29 KB, patch)
2010-03-03 12:14 UTC, Tim Lauridsen
needs-work Details | Review
Migrate from libglade to GtkBuilder (50.82 KB, patch)
2010-05-19 17:19 UTC, Francisco Rojas
needs-work Details | Review
Make the postr.glade glade3 compatible (21.36 KB, patch)
2010-09-13 03:03 UTC, Germán Poo-Caamaño
committed Details | Review
Updated patch to migrate from libglade to GtkBuilder (50.40 KB, patch)
2010-09-14 02:28 UTC, Francisco Rojas
none Details | Review

Description Germán Poo-Caamaño 2009-11-05 03:49:40 UTC
The current GUI of Postr uses glade-2.0.dtd, which is shown badly on Glade-3.
The script for conversion does not do any better.  It is required to migrate it
whith a bit of care.

It should not be hard, but it should not produce any regression.
Comment 1 Tim Lauridsen 2010-03-03 12:14:15 UTC
Created attachment 155129 [details] [review]
convert the postr.glade to glade3 format

I have modified the glade file so it can be used with glade3.

First step in converting to GtkBuilder
Comment 2 André Klapper 2010-04-15 15:30:11 UTC
Maintainers: ping - can this patch get a review/commit?
Comment 3 Francisco Rojas 2010-04-28 03:28:55 UTC
Review of attachment 155129 [details] [review]:

sorry the late answer.  I reviewed and tested the patch, it works fine. Thanks Tim for working in this.
Comment 4 Francisco Rojas 2010-04-28 03:38:49 UTC
I forgot to added that, this patch doesn't fully fix the bug, only it make the UI compatible with glade-3. However it's a good base for start.
Comment 5 Francisco Rojas 2010-05-19 17:19:23 UTC
Created attachment 161475 [details] [review]
Migrate from libglade to GtkBuilder

I didn't deleted the glade files although isn't necessary anymore
Comment 6 Francisco Rojas 2010-09-13 00:41:00 UTC
I've applied this patch some time ago in my own branch[1] and it works fine

[1] http://gitorious.org/~frojasg/postr/frojasgs-postr
Comment 7 Germán Poo-Caamaño 2010-09-13 02:24:21 UTC
Review of attachment 161475 [details] [review]:

It would be nice being able to edit the ui file using Glade-3.
As far as I seen, the GtkActions are not properly recognized.

It is also possible to use Menu Items in new versions of libglade,
so, it would be possible to use Glade-3 for edit them.  It should
not be a big deal to adapt them.

However, postr.py does not apply in master (we have had some
changes after we applied other patches.  Given you know the code,
can you update postr.py?

::: src/postr.ui
@@ +12,3 @@
+        <child>
+          <object class="GtkAction" id="add_photos">
+            <property name="stock_id">gtk-missing-image</property>

It does not look very good the stock icon 'gtk-missing-image' spread all around the menu
Comment 8 Germán Poo-Caamaño 2010-09-13 02:45:04 UTC
Review of attachment 155129 [details] [review]:

It is just a matter of associate the proper icons with each menu
or just drop them out.

::: src/postr.glade
@@ +35,2 @@
                             <property name="visible">True</property>
+                            <property name="stock">gtk-missing-image</property>

The problem with this patch is the conversion of the menus and its associated icons.  Almost all of them were supplied with gtk-missing-image, which is an ugly icon.
Comment 9 Germán Poo-Caamaño 2010-09-13 03:03:01 UTC
Created attachment 170112 [details] [review]
Make the postr.glade glade3 compatible

Fixed patch from Tim Lauridsen to add support for Glade-3.
Comment 10 Germán Poo-Caamaño 2010-09-13 03:06:43 UTC
Review of attachment 170112 [details] [review]:

I just committed it.
Comment 11 Francisco Rojas 2010-09-14 02:28:29 UTC
Created attachment 170212 [details] [review]
Updated patch to migrate from libglade to GtkBuilder

I updated the patch to be applied in master, however glade-3 still doesn't recognize the menuitems. 

I tried adapt the menu to be glade-3 compatible, but IMHO was too much effort to such small reward (the result xml is a little messy)
Comment 12 Germán Poo-Caamaño 2012-10-03 23:16:45 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.