GNOME Bugzilla – Bug 600775
Upgrade the UI from libglade to GtkBuilder
Last modified: 2012-10-03 23:16:45 UTC
The current GUI of Postr uses glade-2.0.dtd, which is shown badly on Glade-3. The script for conversion does not do any better. It is required to migrate it whith a bit of care. It should not be hard, but it should not produce any regression.
Created attachment 155129 [details] [review] convert the postr.glade to glade3 format I have modified the glade file so it can be used with glade3. First step in converting to GtkBuilder
Maintainers: ping - can this patch get a review/commit?
Review of attachment 155129 [details] [review]: sorry the late answer. I reviewed and tested the patch, it works fine. Thanks Tim for working in this.
I forgot to added that, this patch doesn't fully fix the bug, only it make the UI compatible with glade-3. However it's a good base for start.
Created attachment 161475 [details] [review] Migrate from libglade to GtkBuilder I didn't deleted the glade files although isn't necessary anymore
I've applied this patch some time ago in my own branch[1] and it works fine [1] http://gitorious.org/~frojasg/postr/frojasgs-postr
Review of attachment 161475 [details] [review]: It would be nice being able to edit the ui file using Glade-3. As far as I seen, the GtkActions are not properly recognized. It is also possible to use Menu Items in new versions of libglade, so, it would be possible to use Glade-3 for edit them. It should not be a big deal to adapt them. However, postr.py does not apply in master (we have had some changes after we applied other patches. Given you know the code, can you update postr.py? ::: src/postr.ui @@ +12,3 @@ + <child> + <object class="GtkAction" id="add_photos"> + <property name="stock_id">gtk-missing-image</property> It does not look very good the stock icon 'gtk-missing-image' spread all around the menu
Review of attachment 155129 [details] [review]: It is just a matter of associate the proper icons with each menu or just drop them out. ::: src/postr.glade @@ +35,2 @@ <property name="visible">True</property> + <property name="stock">gtk-missing-image</property> The problem with this patch is the conversion of the menus and its associated icons. Almost all of them were supplied with gtk-missing-image, which is an ugly icon.
Created attachment 170112 [details] [review] Make the postr.glade glade3 compatible Fixed patch from Tim Lauridsen to add support for Glade-3.
Review of attachment 170112 [details] [review]: I just committed it.
Created attachment 170212 [details] [review] Updated patch to migrate from libglade to GtkBuilder I updated the patch to be applied in master, however glade-3 still doesn't recognize the menuitems. I tried adapt the menu to be glade-3 compatible, but IMHO was too much effort to such small reward (the result xml is a little messy)
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.