After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 600736 - Compile with GSEAL enabled
Compile with GSEAL enabled
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
2.29.x
Other Linux
: Normal normal
: ---
Assigned To: gok-maint
gok-maint
Depends on:
Blocks: 585391
 
 
Reported: 2009-11-04 21:16 UTC by Gerd Kohlberger
Modified: 2009-11-15 13:43 UTC
See Also:
GNOME target: 2.30.x
GNOME version: ---

Attachments
Patch (35.90 KB, patch)
2009-11-04 21:33 UTC, Gerd Kohlberger 		accepted-commit_now Details | Review

Description Gerd Kohlberger 2009-11-04 21:16:18 UTC 
To be ready for GNOME/GTK+ 3 GOK should be able to build with -DGSEAL_ENABLE

See http://live.gnome.org/GnomeGoals/UseGseal for details.
Comment 1 Gerd Kohlberger 2009-11-04 21:33:23 UTC 
Created attachment 146953 [details] [review]
Patch

The patch increases the minimum gtk+ dependency to 2.18.
Comment 2 Ben Konrath 2009-11-10 20:01:42 UTC 
Review of attachment 146953 [details] [review]:

Gerd, the patch looks good. GOK complies with make CFLAGS+="-DGSEAL_ENABLE". I smoke tested most of the functionality that the patch touches and things are good. The only suggestion that I have is to add your copyright information to the files that don't already have it but this is not a required change. Thanks! Ben
Comment 3 Gerd Kohlberger 2009-11-15 13:43:12 UTC 
Thanks for the review Ben. I've added the missing copyright info and committed to master.

http://git.gnome.org/cgit/gok/commit/?id=2420bd35ffb3dbb05547c6b978a410ecee3ae189