After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 599443 - Add checkbox for unlimited scrollback
Add checkbox for unlimited scrollback
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
: 504733 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2009-10-23 20:26 UTC by Behdad Esfahbod
Modified: 2009-12-15 05:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Behdad Esfahbod 2009-10-23 20:26:41 UTC
Now that we're out of UI freeze, lets add a checkbox for "Unlimited" scrollback lines.  It should simply pass G_MAXINT to vte_terminal_set_scrollback_lines().

That function actually takes glong, but the internal code works with guint.  That's something to fix at some point.
Comment 1 Behdad Esfahbod 2009-10-23 22:37:01 UTC
Ok, I cleaned up vte to use glong/gulong.  Also changed vte_terminal_set_scrollback_lines() to interpret negative numbers as "unlimited" and change them to G_MAXLONG.  So you can pass -1 for unlimited now.
Comment 2 Behdad Esfahbod 2009-12-03 19:53:20 UTC
We were talking about it the other day and people suggested that instead of a
checkbox, we can change the spin button to have a unlimited option?  Something
like this.  Here's what dcbw said:

(01:58:22 PM) dcbw: behdad: no,
http://git.gnome.org/cgit/network-manager-applet/tree/src/connection-editor/page-wired.c
(01:58:42 PM) dcbw: behdad: if you wanted an example
(01:59:01 PM) dcbw:     g_signal_connect (priv->mtu, "output",                 
     G_CALLBACK (ce_spin_output_with_default),                      
GINT_TO_POINTER (mtu_def)); 
(01:59:44 PM) dcbw: behdad: which uses the ce_spin_output_with_default()
function from this file:
http://git.gnome.org/cgit/network-manager-applet/tree/src/connection-editor/ce-page.c
(02:00:56 PM) dcbw: behdad: basically, whenever the value changes on the
spinbox you'll get 'output' and you can then stuff whatever value you'd like
into the spinbutton's GtkEntry
Comment 3 Behdad Esfahbod 2009-12-03 19:53:29 UTC
*** Bug 504733 has been marked as a duplicate of this bug. ***
Comment 4 Behdad Esfahbod 2009-12-15 05:31:28 UTC
Pushed to master.  Also fixed an overflow bug in vte, so vte master is needed for correct operation.