GNOME Bugzilla – Bug 599443
Add checkbox for unlimited scrollback
Last modified: 2009-12-15 05:31:28 UTC
Now that we're out of UI freeze, lets add a checkbox for "Unlimited" scrollback lines. It should simply pass G_MAXINT to vte_terminal_set_scrollback_lines(). That function actually takes glong, but the internal code works with guint. That's something to fix at some point.
Ok, I cleaned up vte to use glong/gulong. Also changed vte_terminal_set_scrollback_lines() to interpret negative numbers as "unlimited" and change them to G_MAXLONG. So you can pass -1 for unlimited now.
We were talking about it the other day and people suggested that instead of a checkbox, we can change the spin button to have a unlimited option? Something like this. Here's what dcbw said: (01:58:22 PM) dcbw: behdad: no, http://git.gnome.org/cgit/network-manager-applet/tree/src/connection-editor/page-wired.c (01:58:42 PM) dcbw: behdad: if you wanted an example (01:59:01 PM) dcbw: g_signal_connect (priv->mtu, "output", G_CALLBACK (ce_spin_output_with_default), GINT_TO_POINTER (mtu_def)); (01:59:44 PM) dcbw: behdad: which uses the ce_spin_output_with_default() function from this file: http://git.gnome.org/cgit/network-manager-applet/tree/src/connection-editor/ce-page.c (02:00:56 PM) dcbw: behdad: basically, whenever the value changes on the spinbox you'll get 'output' and you can then stuff whatever value you'd like into the spinbutton's GtkEntry
*** Bug 504733 has been marked as a duplicate of this bug. ***
Pushed to master. Also fixed an overflow bug in vte, so vte master is needed for correct operation.