GNOME Bugzilla – Bug 598761
[mpegaudioparse] Reduce processing time by 2
Last modified: 2009-10-24 18:39:03 UTC
50% of the processing time is spent... getting the nick for the mode enumeration through the "oh so efficient" glib system. Proposed patch just does gets it from our local code.
Created attachment 145657 [details] [review] mpegaudioparse: Don't use expensive glib ways to get an enum nick. This removes a good 50% of processing time for parsing a buffer. We do this by simply... getting the nicks that we already have handy instead of going through the expensive glib system.
Hah, that's scary :) Patch looks good
I didn't mark this as a blocker btw, since the mpeg parsing itself is minimal to start with... so over the full process that gain isn't *that* impressive on desktop computers. Maybe it would be of interest to embedded devices though. I'm not gonna push for it to go in. If Jan thinks it should go in, then fine, else it can wait.
commit 33b4528a0ee79ff10475d2aa07d6783553c40cf5 Author: Edward Hervey <bilboed@bilboed.com> Date: Sat Oct 17 13:46:13 2009 +0200 mpegaudioparse: Don't use expensive glib ways to get an enum nick. Fixes #598761 This removes a good 50% of processing time for parsing a buffer. We do this by simply... getting the nicks that we already have handy instead of going through the expensive glib system.