After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598297 - make check fails when any --disable option which changes the API has been used
make check fails when any --disable option which changes the API has been used
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-13 15:47 UTC by Peter Kjellerstedt
Modified: 2009-10-14 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Suggested solution to let make check work with --disable options (554 bytes, patch)
2009-10-13 15:47 UTC, Peter Kjellerstedt
committed Details | Review

Description Peter Kjellerstedt 2009-10-13 15:47:28 UTC
Created attachment 145362 [details] [review]
Suggested solution to let make check work with --disable options

Since make check causes make check-exports to be run, any changes to the API
due to the use of any --disable option, e.g., --disable-loadsave, will cause
the check test to fail. 

The attached patch is a suggested solution to this. It disables check-exports
from being run by make check if either of --disable-loadsave,
--disable-registry and --disable-trace has been used (those were the --disable
options I could find which change the API; there may be more).
Comment 1 Sebastian Dröge (slomo) 2009-10-14 06:58:18 UTC
commit 1b569d8cb42b6bbcfad261166c7b009e61587ad3
Author: Peter Kjellerstedt <pkj@axis.com>
Date:   Wed Oct 14 08:50:31 2009 +0200

    build: Only run make check-exports if no public API was disabled
    
    Fixes bug #598297.