After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 598139 - faad element leaks itself.
faad element leaks itself.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-10-12 07:52 UTC by Peter Christoffersen
Modified: 2009-10-13 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix object leak in faad element (568 bytes, patch)
2009-10-12 16:43 UTC, Peter Christoffersen 		committed Details | Review

Description Peter Christoffersen 2009-10-12 07:52:53 UTC 
Hi,

I noticed that the faad element takes a reference to itself at the top of the gst_faad_setcaps function (via the gst_pad_get_parent function). 

As far as I can tell it never releases that reference again.

I've attached a patch to fix the problem.

--
  Peter Christoffersen
Comment 1 Jan Schmidt 2009-10-12 16:00:58 UTC 
Attachment didn't arrive. You're right that it leaks.
Comment 2 Peter Christoffersen 2009-10-12 16:43:29 UTC 
Created attachment 145288 [details] [review]
Fix object leak in faad element

Sorry, 

Here is the patch. It's pretty trivial, I just added gst_object_unref to all exit points of the gst_faad_setcaps function.
Comment 3 Sebastian Dröge (slomo) 2009-10-13 14:02:08 UTC 
commit 7eb553e2debfd279d6b1b6fc95b90cdce14d7010
Author: Peter Christoffersen <gnome-bugzilla@plyt.dk>
Date:   Tue Oct 13 16:01:26 2009 +0200

    faad2: Don't leak element reference in the setcaps function
    
    Fixes bug #598139.