After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595791 - Use accessor functions instead direct access (use GSEAL GnomeGoal)
Use accessor functions instead direct access (use GSEAL GnomeGoal)
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on: 163251 328069 345349 594535
Blocks: 585391
 
 
Reported: 2009-09-21 02:36 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-06-12 22:07 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Use accessor functions instead direct access (59.41 KB, patch)
2009-09-21 02:44 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Use gtk_statusbar_get_message_area() (2.26 KB, patch)
2009-11-12 20:26 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use accessor functions instead direct accessv. Second patch (2.47 KB, patch)
2010-02-11 02:33 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use accessor functions instead direct accessv. Second patchv2 (3.12 KB, patch)
2010-02-11 02:43 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review
Do not access im_context GtkEntry element directly (971 bytes, patch)
2010-05-10 00:32 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2009-09-21 02:36:30 UTC
To be ready for GNOME 3 should be able to build with -DGSEAL_ENABLE

See http://live.gnome.org/GnomeGoals/UseGseal for more details
Comment 1 Javier Jardón (IRC: jjardon) 2009-09-21 02:44:30 UTC
Created attachment 143563 [details] [review]
Use accessor functions instead direct access

GTK+ 2.17.10 is now the required version
I've used all the GTK+ 2.17.11 api available, still missing:

GTK_WIDGET_REALIZED (GTK_WIDGET ())
GTK_WIDGET_MAPPED (GTK_WIDGET ()) See bug #69872

GTK_ENTRY->im_context See bug #163251

GTK_STATUSBAR->frame
GTK_STATUSBAR->label  See bug #594535

GTK_MESSAGE_DIALOG->label
Comment 2 Xan Lopez 2009-09-22 09:39:32 UTC
(In reply to comment #1)
> Created an attachment (id=143563) [details]
> Use accessor functions instead direct access
> 
> GTK+ 2.17.10 is now the required version
> I've used all the GTK+ 2.17.11 api available, still missing:
> 
> GTK_WIDGET_REALIZED (GTK_WIDGET ())
> GTK_WIDGET_MAPPED (GTK_WIDGET ()) See bug #69872
> 
> GTK_ENTRY->im_context See bug #163251
> 
> GTK_STATUSBAR->frame
> GTK_STATUSBAR->label  See bug #594535
> 
> GTK_MESSAGE_DIALOG->label

Thanks, I have pushed this to master (bumping the dependency to 2.17.11 since that's already released). Keeping this open for the remaining issues.
Comment 3 Javier Jardón (IRC: jjardon) 2009-11-12 20:26:32 UTC
Created attachment 147609 [details] [review]
Use gtk_statusbar_get_message_area()

I'm not very sure if this patch exactly substitute the previous behaviour, please test.
Comment 4 Javier Jardón (IRC: jjardon) 2010-02-11 02:33:09 UTC
Created attachment 153500 [details] [review]
Use accessor functions instead direct accessv. Second patch

Substitute GTK_WIDGET_MAPPED() and GTK_WIDGET_REALIZED()
GTK+ required version bumped to 2.19.5
Comment 5 Javier Jardón (IRC: jjardon) 2010-02-11 02:43:54 UTC
Created attachment 153501 [details] [review]
Use accessor functions instead direct accessv. Second patchv2

Oops, sorry, here the correct patch
Comment 6 Xan Lopez 2010-02-11 14:28:57 UTC
Comment on attachment 153501 [details] [review]
Use accessor functions instead direct accessv. Second patchv2

Looks good.
Comment 7 Xan Lopez 2010-02-11 14:29:49 UTC
Comment on attachment 147609 [details] [review]
Use gtk_statusbar_get_message_area()

This was already fixed.
Comment 8 Javier Jardón (IRC: jjardon) 2010-02-11 14:49:26 UTC
Comment on attachment 153501 [details] [review]
Use accessor functions instead direct accessv. Second patchv2

commit eb55fc7974c51d26ec5e539d7214787d1fac9a07
Comment 9 Javier Jardón (IRC: jjardon) 2010-02-11 14:50:00 UTC
Comment on attachment 147609 [details] [review]
Use gtk_statusbar_get_message_area()

Mark this patch as obsolete
Comment 10 André Klapper 2010-05-08 16:00:13 UTC
Issue left to fix (before I run into the problem of missing WebKit-1.0.gir here):

lib/ephy-gui.c: In function ‘ephy_gui_message_dialog_set_wrap_mode’:
ephy-gui.c:518: error: ‘GtkMessageDialog’ has no member named ‘label’

src/bookmarks/ephy-bookmark-action.c: In function ‘entry_key_press_cb’:
ephy-bookmark-action.c:418: error: ‘GtkEntry’ has no member named ‘im_context’

src/pdm-dialog.c: In function ‘pdm_dialog_show_clear_all_dialog’:
pdm-dialog.c:396: error: ‘GtkMessageDialog’ has no member named ‘label’
pdm-dialog.c:400: error: ‘GtkMessageDialog’ has no member named ‘label’
Comment 11 Javier Jardón (IRC: jjardon) 2010-05-10 00:32:51 UTC
Created attachment 160677 [details] [review]
Do not access im_context GtkEntry element directly

This patch soles the
"error: ‘GtkEntry’ has no member named ‘im_context’"
problem
Comment 12 André Klapper 2010-06-01 13:57:40 UTC
Can somebody review the last patch please?
Comment 13 Xan Lopez 2010-06-01 14:27:40 UTC
Comment on attachment 160677 [details] [review]
Do not access im_context GtkEntry element directly

ok
Comment 14 Javier Jardón (IRC: jjardon) 2010-06-01 17:30:22 UTC
Comment on attachment 160677 [details] [review]
Do not access im_context GtkEntry element directly

commit 685e4e45b4d984d67f93a04701239baddb16ab0d
Comment 15 Xan Lopez 2010-06-12 19:22:24 UTC
(In reply to comment #10)
> Issue left to fix (before I run into the problem of missing WebKit-1.0.gir
> here):
> 
> lib/ephy-gui.c: In function ‘ephy_gui_message_dialog_set_wrap_mode’:
> ephy-gui.c:518: error: ‘GtkMessageDialog’ has no member named ‘label’
> 
> src/bookmarks/ephy-bookmark-action.c: In function ‘entry_key_press_cb’:
> ephy-bookmark-action.c:418: error: ‘GtkEntry’ has no member named ‘im_context’
> 
> src/pdm-dialog.c: In function ‘pdm_dialog_show_clear_all_dialog’:
> pdm-dialog.c:396: error: ‘GtkMessageDialog’ has no member named ‘label’
> pdm-dialog.c:400: error: ‘GtkMessageDialog’ has no member named ‘label’

Any idea of what are we supposed to do with the label accesses in GtkMessageDialog?
Comment 16 Xan Lopez 2010-06-12 22:07:36 UTC
I hacked my way around this, so we can close the bug since epiphany compiles with GSEAL enabled now.