After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 595454 - [cddabasesrc] uri format change breaks rhythmbox
[cddabasesrc] uri format change breaks rhythmbox
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2009-09-17 13:12 UTC by Jonathan Matthew
Modified: 2009-09-17 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.28 KB, patch)
2009-09-17 13:48 UTC, Jonathan Matthew 		committed Details | Review

Description Jonathan Matthew 2009-09-17 13:12:48 UTC 
The changes to the cdda:// URI format in bug 321532 cause CD ripping and playback to fail in rhythmbox, since its URIs are in the form cdda://track#device.  This previously worked because the URI fragment was being ignored, but now cddabasesrc rejects the URI.  For backwards compatibility, I think cddabasesrc should ignore the URI fragment if it looks like a device path.
Comment 1 Jonathan Matthew 2009-09-17 13:48:01 UTC 
Created attachment 143344 [details] [review]
patch
Comment 2 Sebastian Dröge (slomo) 2009-09-17 14:58:55 UTC 
commit ec06e93ab76f15714a520a6fedea78e6038e048a
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Sep 17 16:57:48 2009 +0200

    cddabasesrc: Fix string leaks in the unit test and a leak in cddabasesrc

commit 304fdc34f82575c33f9979beb73d668ee22a930a
Author: Jonathan Matthew <jonathan@d14n.org>
Date:   Thu Sep 17 23:42:52 2009 +1000

    cddabasesrc: ignore URI fragments that look like device paths
    
    Rhythmbox uses cdda:// URIs of the form cdda://track#device, which
    worked before the fix for bug #321532.
    
    Also adds a check for negative track numbers and some unit tests for URI
    parsing.
    
    Fixes bug #595454.